DefaultClientRequestObservationConvention generates wrong uri tag when missing path#33867
Closed
ZLATAN628 wants to merge 1 commit into
Closed
DefaultClientRequestObservationConvention generates wrong uri tag when missing path#33867ZLATAN628 wants to merge 1 commit into
ZLATAN628 wants to merge 1 commit into
Conversation
|
@ZLATAN628 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ZLATAN628 Thank you for signing the Contributor License Agreement! |
bclozel
pushed a commit
that referenced
this pull request
Nov 12, 2024
Prior to this commit, a client sending a request to "https://example.org" would record the wrong URI tag as "/https://example.org". This commit ensures that the scheme+host part is matched correctly in the default client observation conventions. See gh-33867
bclozel
pushed a commit
that referenced
this pull request
Nov 12, 2024
Prior to this commit, a client sending a request to "https://example.org" would record the wrong URI tag as "/https://example.org". This commit ensures that the scheme+host part is matched correctly in the default client observation conventions. See gh-33867
Member
|
Thanks for your contribution @ZLATAN628 this has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #33863