Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JReinhold
Copy link
Contributor

@JReinhold JReinhold commented May 6, 2025

What I did

In combination with storybookjs/addon-svelte-csf#304

The Svelte CSF addon has been promoted to stable, so we no longer need to install the next version of it during init. We don't even need to check for Svelte 4 vs 5 versions, because Storybook 9 does not support Svelte 4 anymore.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Simplified SvelteKit and Svelte generators by removing version-specific handling of @storybook/addon-svelte-csf, now defaulting to the latest stable version since Storybook 9 only supports Svelte 5.

  • Modified code/lib/create-storybook/src/generators/SVELTEKIT/index.ts to install latest stable version of addon-svelte-csf
  • Modified code/lib/create-storybook/src/generators/SVELTE/index.ts to remove Svelte version checking logic
  • Removed code/lib/create-storybook/src/generators/SVELTE/index.test.ts as version-specific tests are no longer needed

@JReinhold JReinhold self-assigned this May 6, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@JReinhold JReinhold added dependencies svelte ci:daily Run the CI jobs that normally run in the daily job. labels May 6, 2025
@nx-cloud
Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit 0f9e370.

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 10s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 19:50:25 UTC

@nx-cloud
Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit 0f9e370.

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 19:49:45 UTC

@JReinhold JReinhold merged commit b342350 into next May 6, 2025
98 of 107 checks passed
@JReinhold JReinhold deleted the jeppe/use-latest-of-svelte-csf branch May 6, 2025 22:05
@github-actions github-actions bot mentioned this pull request May 6, 2025
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. dependencies svelte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants