Telemetry: Use version from our package.json for storybookVersion
#31577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
8 tasks
|
View your CI Pipeline Execution ↗ for commit 3de59b7.
☁️ Nx Cloud last updated this comment at |
context.storybookVersioncontext.storybookVersion
context.storybookVersionstorybookVersion
shilman
requested changes
May 27, 2025
shilman
requested changes
May 27, 2025
Member
|
Lgtm |
1 similar comment
Member
|
Lgtm |
shilman
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be very precise about the storybook version rather than try and infer it from the user's config.
What I did
Read the version directly from our own
package.json(bundled in). Also addstorybookVersiontocontext, notmetadataas it is more appropriate and isn't inferred.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31577-sha-bd24b0b9. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-31577-sha-bd24b0b9tom/refactor-storybookId-in-telemetrybd24b0b91748357890)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31577Greptile Summary
Refactors Storybook's version tracking in telemetry to use direct version from package.json instead of inferring it from user configurations, improving accuracy and reliability of version reporting.
code/core/src/cli/bin/index.tsto import version directly from package.json instead of usingversions.storybookcode/core/src/telemetry/telemetry.tsto include Storybook version in global telemetry contextstorybookVersionfield fromcode/core/src/telemetry/storybook-metadata.tsscripts/event-log-checker.tsto test storybookVersion in both boot and main events