fix: fall back to non-relative resolution when calling resolve(...) outside an event context
#14532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14513. (I also added a drive-by fix for the fact that non-relative resolution ignored
paths.base.)In the process of doing this, I realised that
resolve(...)will give incorrect results when called in the context of a remote function, since thepathnameis always/in that case. Not entirely sure how best to handle it — we should probably fall back to non-relative resolution in that case too? (Making it relative to the route from which the remote function was called isn't a solution, because then the result is non-deterministic and non-cacheable.)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits