Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: include method definitions in class private fields #14365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: include method definitions in class private fields #14365

merged 2 commits into from
Nov 19, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 19, 2024 •
edited
Loading

Closes #14364

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b0cb0e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti marked this pull request as ready for review November 19, 2024 21:30
@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14365-svelte.vercel.app/

this is an automated message

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14365

@paoloricciuti paoloricciuti merged commit 32a1453 into main Nov 19, 2024
11 checks passed
@paoloricciuti paoloricciuti deleted the class-methods-disabiguate branch November 19, 2024 21:38
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class $state properties auto-reserve #name properties
2 participants
@paoloricciuti @Rich-Harris