Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.5
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.7
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Mar 16, 2022

  1. Configuration menu
    Copy the full SHA
    74236fc View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Merge branch '4.4' into 5.4

    * 4.4:
      [VarExporter] fix tests on Windows
      [GHA] Fix psalm job
      Fix CS
      [PropertyInfo] strip only leading `\` when unknown docType
      ignoring exception from sem_get in SemaphoreStore Lock component, preventing of error: identifier removed
      [Console] Fix compact table style to avoid outputting a leading space
      [Mailer] Use recipients in sendmail transport
      [Asset] Update the error message when assets are not built
    nicolas-grekas committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    0a4f498 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. [Console] Fix exit status on uncaught exception with negative code

    As described in #45850, if an application threw an exception with
    the `code` property set to a negative number this could in some
    cases cause the process to appear to exit 'successfully' with a
    zero exit status.
    
    Exiting with any negative number produces potentially unexpected
    results - the reported exit status will not appear to match the
    value that was set. This is due to the binary handling /
    truncation of exit codes.
    
    This may theoretically break BC for applications that were
    intentionally throwing exceptions with negative codes and
    performing some action based on that status. However, given they
    would have had to implement an algorithm to map e.g. `-10` in
    PHP to `246` as the actual exit status, it seems unlikely this
    is a common usage. It is certainly outside the defined behaviour
    of POSIX exit codes.
    
    Therefore I believe it is essentially safe to assume that exceptions
    with negative codes are e.g. being thrown by lower-level components,
    and are not intended to set a shell exit status.
    
    Coalescing all negative numbers to 1 matches the existing behaviour
    with other 'invalid' exception codes e.g. empty / zero / non-numeric.
    
    This therefore feels the most robust fix and eliminates any potential
    for confusion.
    
    Fixes #45850
    acoulton committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    bdcc66f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Merge branch '4.4' into 5.4

    * 4.4:
      Fix composer on appveyor
      [PropertyAccess] Fix typo in PropertyAccessor::readProperty() DocBlock
      [VarExporter] Fix exporting objects with readonly properties
      [ExpressionLanguage] Fix matches when the regexp is not valid
      [Messenger] Add mysql indexes back and work around deadlocks using soft-delete
      [Validator] Fix File constraint invalid max size exception message
      [Console] Fix exit status on uncaught exception with negative code
    nicolas-grekas committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9002752 View commit details
    Browse the repository at this point in the history
Loading