Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.2.5
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.2.7
Choose a head ref
  • 17 commits
  • 47 files changed
  • 9 contributors

Commits on Jan 6, 2023

  1. Configuration menu
    Copy the full SHA
    e65c925 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    fd78f92 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch '5.4' into 6.2

    * 5.4:
      Fix LICENSE CI check
      fixes retrieving multiple values for extra fields
      [String] Remove duplicates in fold maps
      fail with a meaningful error when a needed package is missing
      [DependencyInjection] Fix combinatory explosion when autowiring union and intersection types
      Update license years (last time)
      [Tests] New iteration of removing `$this` occurrences in future static data providers
    fabpot committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c2ac8b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Configuration menu
    Copy the full SHA
    8ae1b60 View commit details
    Browse the repository at this point in the history
  2. Merge branch '5.4' into 6.2

    * 5.4:
      [Serializer] Fix CsvEncoder decode on empty data
      [Tests] Migrate data providers to static ones
      stop using assertObjectHasAttribute()/assertObjectHasNotAttribute()
      [Dotenv] Fix phpdoc Dotenv
      [Config] Fix phpdoc nullable
      Fix some typos
    nicolas-grekas committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    47972b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. minor #49253 [PHPUnit 10] Use TestCase suffix for abstract tests in…

    … `/Tests/` (OskarStark)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Refs symfony/symfony#49233
    | License       | MIT
    | Doc PR        | n/a
    
    Replaces #49234
    
    Using `Test` suffix is deprecated since PHPUnit 10
    
    Spotted in
    * symfony/symfony#49233
    
    Commits
    -------
    
    cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
    nicolas-grekas committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4b81c20 View commit details
    Browse the repository at this point in the history
  2. Merge branch '5.4' into 6.2

    * 5.4:
      minor #49253 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/` (OskarStark)
    nicolas-grekas committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    4c631f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Configuration menu
    Copy the full SHA
    0b4af14 View commit details
    Browse the repository at this point in the history
  2. Merge branch '5.4' into 6.2

    * 5.4:
      Migrate to `static` data providers using `rector/rector`
    nicolas-grekas committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    10da114 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc04b7a View commit details
    Browse the repository at this point in the history
  4. Merge branch '5.4' into 6.2

    * 5.4:
      [Security] fix compat with security-core v6
      use proper methods to assert exception messages contain certain strings
    derrabus committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    005c745 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. CS fix

    nicolas-grekas committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    a39ab00 View commit details
    Browse the repository at this point in the history
  2. Merge branch '5.4' into 6.2

    * 5.4:
      CS fix
      Fix test provider
    nicolas-grekas committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    12b1042 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. bug #48897 [Console] fix clear of section with question (maxbeckers)

    This PR was merged into the 6.2 branch.
    
    Discussion
    ----------
    
    [Console] fix clear of section with question
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  6.2
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #47411
    | License       | MIT
    | Doc PR        | n/a
    
    This PR fixes the problems to clear a section with a question included.
    
    Example Code:
    ```
        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $section1 = $output->section();
            $io = new SymfonyStyle($input, $section1);
    
            $output->writeln("foo");
    
            $countdown = 3;
            while ($countdown > 0) {
                $section1->clear();
                $io->writeln('start ' . $countdown);
                $io->write('foo');
                $io->write(' and bar'.\PHP_EOL);
                $givenAnswer = $io->ask('Dummy question?');
                $section1->write('bar');
                $countdown--;
            }
    
            return self::SUCCESS;
        }
    ```
    
    Output loop 1:
    ![Screenshot 2023-01-06 142630](https://user-images.githubusercontent.com/11738128/211021767-e4109951-0519-4763-bdd0-6504ee875b46.png)
    
    Output loop 1:
    ![Screenshot 2023-01-06 142653](https://user-images.githubusercontent.com/11738128/211021793-db987c4a-1ac5-422d-a8b9-f6c3f4a23c7f.png)
    
    There was already a fix #48089 to be merged in 6.1, but the problem was that there were some changes in 6.2, so it was not possible to merge it into 6.2.
    
    So this fix is only working for 6.2, but perhaps we could find a solution as well for the older versions. But because of the changes of console it was not possible to find a solution working for all versions.
    
    `@chalasr` this fix is still with the newline always `true`
    https://github.com/symfony/symfony/blob/4cf9855debc26e4323429ac8d87f02df582e2893/src/Symfony/Component/Console/Output/ConsoleSectionOutput.php#L181
    A change of the newline to `$newline` would change the behavior. Maybe we could change that in symfony 7.
    
    To make it easier to test is here a zip with 2 testcommands in the root and the changed vendors.
    [test-48089.zip](https://github.com/symfony/symfony/files/10360423/test-48089.zip)
    
    Commits
    -------
    
    f4c551805b [Console] fix clear of section with question
    chalasr committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    fc0e346 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Configuration menu
    Copy the full SHA
    0a3c371 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c77433d View commit details
    Browse the repository at this point in the history
  3. Merge branch '5.4' into 6.2

    * 5.4:
      [Console] Fix ApplicationTest::testSetSignalsToDispatchEvent() when ran alone
    fabpot committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    cbad09e View commit details
    Browse the repository at this point in the history
Loading