Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/serializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.1
Choose a base ref
...
head repository: symfony/serializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.1.2
Choose a head ref
  • 18 commits
  • 7 files changed
  • 6 contributors

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    d920301 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    9a3acd7 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    311006a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. bug #52699 [Serializer] [PropertyAccessor] Ignore non-collection inte…

    …rface generics (mtarld)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] [PropertyAccessor] Ignore non-collection interface generics
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #41996 #49924
    | License       | MIT
    
    `PhpDocExtractor` and `PhpStanDocExtractor` are following an old version of PSR-5 with used to define collections as the following:
    ```
    generic = collection-type "<" [type-expression "," *SP] type-expression ">"
    ```
    But, it does conflict with non-collection generics.
    
    This issue will automatically be solved if the `TypeInfo` is merged in Symfony. But for older versions (<7.1 at least), it needs a fix.
    
    ~I was not able to find a proper bug fix without introducing a BC break, so this PR proposes to opt-on the "non-collection generics" parsing, such as `stcClass<int>` for example.~
    
    ~To opt-out from parsing these generics, it'll be required to set `ignore_docblock_generics` in the context. And this key/value will become obsolete as soon as the `TypeInfo` is introduced.~
    
    ~I'm not sure how to proceed though, should we only merge it in 5.4, and 6.3 supposing that the `TypeInfo` might be merged in 7.x? Should we document it only in these branches?~
    
    EDIT: I finally ignored PHPDoc generics that aren't well known collection generic types so that the process will fall back to other resolvers (such as reflection resolver for example)
    
    Commits
    -------
    
    e31aeeb [PropertyAccessor] Fix unexpected collection when generics
    fabpot committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8cdef77 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Configuration menu
    Copy the full SHA
    d1ffba3 View commit details
    Browse the repository at this point in the history
  2. bug #57187 [Serializer] Fix ObjectNormalizer with property path (Hy…

    …peMC)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] Fix `ObjectNormalizer` with property path
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #54983
    | License       | MIT
    
    Caused by #52917.
    
    The `ObjectNormalizer::isAllowedAttribute()` method doesn't work with property paths, this is an attempt to fix the problem.
    
    Commits
    -------
    
    3857545 [Serializer] Fix `ObjectNormalizer` with property path
    fabpot committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    296df0c View commit details
    Browse the repository at this point in the history
  3. bug #57341 [Serializer] properly handle invalid data for false/true t…

    …ypes (xabbuh)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] properly handle invalid data for false/true types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix symfony/symfony#57320 (comment)
    | License       | MIT
    
    Commits
    -------
    
    d35d4a3 properly handle invalid data for false/true types
    xabbuh committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3fd3eca View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch '5.4' into 6.4

    * 5.4: (21 commits)
      [SecurityBundle] Add `provider` XML attribute to the authenticators it’s missing from
      [DoctrineBridge] Test reset with a true manager
      Sync php-cs-fixer config file with 7.2
      [HttpClient] Fix parsing SSE
      [Notifier] Fix thread key in GoogleChat bridge
      [HttpKernel][Security] Fix accessing session for stateless request
      [Serializer] Fix `ObjectNormalizer` with property path
      test handling of special "value" constraint option
      [PhpUnitBridge] Add missing import
      [FrameworkBundle] Fix setting default context for certain normalizers
      [57251] Missing translations for Romanian (ro)
      [ErrorHandler] Fix rendered exception code highlighting on PHP 8.3
      [String] Fix #54611 pluralization of -on ending words + singularization of -a ending foreign words
      [Validator] [UniqueValidator] Use correct variable as parameter in (custom) error message
      [Messenger] Comply with Amazon SQS requirements for message body
      fix cssColor HSLA test dataProvider
      properly handle invalid data for false/true types
      chore: upgrade class doc
      add space in error message
      [Messenger] [Amqp] Handle AMQPConnectionException when publishing a message.
      ...
    xabbuh committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4017244 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. fix merge

    xabbuh committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    27859b6 View commit details
    Browse the repository at this point in the history
  2. fix merge

    xabbuh committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7dfc0da View commit details
    Browse the repository at this point in the history
  3. add missing method

    xabbuh committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    240a7bb View commit details
    Browse the repository at this point in the history
  4. Merge branch '6.4' into 7.0

    * 6.4: (29 commits)
      fix tests
      add missing method
      fix merge
      fix test
      fix merge
      fix test
      change test to use a real ObjectManager
      [Mailer] Document the usage of custom headers in Infobip bridge
      [SecurityBundle] Add `provider` XML attribute to the authenticators it’s missing from
      [DoctrineBridge] Test reset with a true manager
      Sync php-cs-fixer config file with 7.2
      [HttpClient] Fix parsing SSE
      [Notifier] Fix thread key in GoogleChat bridge
      [HttpKernel][Security] Fix accessing session for stateless request
      [Serializer] Fix `ObjectNormalizer` with property path
      test handling of special "value" constraint option
      [PhpUnitBridge] Add missing import
      [FrameworkBundle] Fix setting default context for certain normalizers
      [57251] Missing translations for Romanian (ro)
      [ErrorHandler] Fix rendered exception code highlighting on PHP 8.3
      ...
    xabbuh committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1459271 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch '7.0' into 7.1

    * 7.0: (29 commits)
      fix tests
      add missing method
      fix merge
      fix test
      fix merge
      fix test
      change test to use a real ObjectManager
      [Mailer] Document the usage of custom headers in Infobip bridge
      [SecurityBundle] Add `provider` XML attribute to the authenticators it’s missing from
      [DoctrineBridge] Test reset with a true manager
      Sync php-cs-fixer config file with 7.2
      [HttpClient] Fix parsing SSE
      [Notifier] Fix thread key in GoogleChat bridge
      [HttpKernel][Security] Fix accessing session for stateless request
      [Serializer] Fix `ObjectNormalizer` with property path
      test handling of special "value" constraint option
      [PhpUnitBridge] Add missing import
      [FrameworkBundle] Fix setting default context for certain normalizers
      [57251] Missing translations for Romanian (ro)
      [ErrorHandler] Fix rendered exception code highlighting on PHP 8.3
      ...
    xabbuh committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5d03a74 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    6266026 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    7d12e1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a61c583 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. [Serializer] [ObjectNormalizer] Use bool filter when FILTER_BOOL is set

    Maximilian Zumbansen authored and nicolas-grekas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5969918 View commit details
    Browse the repository at this point in the history
  2. bug #57541 [Serializer] [ObjectNormalizer] Use bool filter when FILTE…

    …R_BOOL is set (Maximilian Zumbansen)
    
    This PR was squashed before being merged into the 7.1 branch.
    
    Discussion
    ----------
    
    [Serializer] [ObjectNormalizer] Use bool filter when FILTER_BOOL is set
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.1 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Issues        | Fix #57540 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
    | License       | MIT
    
    With 7.1 it is possible to map query booleans to php bool parameters (https://symfony.com/blog/new-in-symfony-7-1-misc-improvements-part-3#mapping-boolean-query-string-parameters). But as we found out, this only works when the DTO is initialized via `construct`. Otherwise the `FILTER_BOOL` flag will be ignored and e.g. "false" will be deserialized as `true`.
    
    To fix this, I suggest to look for the `FILTER_BOOL` in the context and apply the filter, when the type is `bool` and the data is `string`.
    
    Commits
    -------
    
    6e657e8 [Serializer] [ObjectNormalizer] Use bool filter when FILTER_BOOL is set
    nicolas-grekas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d207767 View commit details
    Browse the repository at this point in the history
Loading