[Messenger] [Redis] Fixed problem where worker stops handling messages on first empty message#48837
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
OskarStark
left a comment
There was a problem hiding this comment.
Please associate your commiter email with your Github account
38c9b3a to
ab0f1d4
Compare
nicolas-grekas
left a comment
There was a problem hiding this comment.
I've rebased + squashed your PR to have a clean git history. Don't forget to fetch before working again on the patch if needed.
About the patch itself, I don't know the topic well enough. Anyone else willing to review in depth?
|
Will do yes. Ping @alexander-schranz also since you provided some guidance in the linked issue (no hurry) |
|
Is there anything I (or anyone else) can do to help with this PR? I'm having the same problem, and this problem is also present in case of an invalid message (can't decode a JSON for example), it should never happen but I have an external system that can push in a stream read by Symfony Messenger, so it would be better if the transport to expect the possibility of an invalid or empty message and rejects this message. |
|
Same problem, any update? |
…s on first empty message
ab0f1d4 to
ce103f1
Compare
nicolas-grekas
left a comment
There was a problem hiding this comment.
I updated the PR to use reject.
|
Thank you @jvmanji. |
Fixed problem where worker stops handling messages on first empty message.