Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] Update security-1.0.xsd to include missing access-token definition#50442

Closed
aegypius wants to merge 0 commit into
symfony:6.2from
aegypius:fix-missing-xsd-definition-for-access-token
Closed

[SecurityBundle] Update security-1.0.xsd to include missing access-token definition#50442
aegypius wants to merge 0 commit into
symfony:6.2from
aegypius:fix-missing-xsd-definition-for-access-token

Conversation

@aegypius
Copy link
Copy Markdown
Contributor

@aegypius aegypius commented May 26, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Add missing access-token definition in the security XSD schema definition as mentioned in review #50432 (review)

@carsonbot
Copy link
Copy Markdown

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@aegypius aegypius marked this pull request as ready for review May 26, 2023 08:05
@aegypius aegypius requested review from chalasr and wouterj as code owners May 26, 2023 08:05
@carsonbot carsonbot added this to the 6.2 milestone May 26, 2023
@carsonbot
Copy link
Copy Markdown

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title fix(security): Update security-1.0.xsd to include missing access-toke… [SecurityBundle] fix(security): Update security-1.0.xsd to include missing access-toke… May 26, 2023
@nicolas-grekas nicolas-grekas changed the title [SecurityBundle] fix(security): Update security-1.0.xsd to include missing access-toke… [SecurityBundle] Update security-1.0.xsd to include missing access-token definition May 26, 2023
@fabpot
Copy link
Copy Markdown
Member

fabpot commented May 26, 2023

Thank you @aegypius.

@fabpot fabpot closed this May 26, 2023
@fabpot fabpot force-pushed the fix-missing-xsd-definition-for-access-token branch from e296886 to abc5e15 Compare May 26, 2023 15:39
fabpot added a commit that referenced this pull request May 26, 2023
…g access-token definition (aegypius)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[SecurityBundle] Update security-1.0.xsd to include missing access-token definition

| Q             | A
| ------------- | ---
| Branch?       |6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Add missing access-token definition in the security XSD schema definition as mentioned in review #50432 (review)

Commits
-------

abc5e15 [SecurityBundle] Update security-1.0.xsd to include missing access-token definition
This was referenced May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants