[Serializer] forward exceptions caught in the AbstractObjectNormalizer#57433
Merged
Conversation
Member
xabbuh
commented
Jun 17, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #57427 |
| License | MIT |
Member
Author
|
this makes sure that |
HypeMC
reviewed
Jun 18, 2024
AbstractObjectNormalizer
Member
|
@nicolas-grekas @xabbuh See #57559, the test passes on 5.4, 6.4 and 7.0, but fails on 7.1. When I apply the changes made in this PR, it passes on 7.1 as well. |
Member
Author
|
@HypeMC 👍 great, I have cherry-picked your commit here too |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
…ct (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Check if exception message in test is correct | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #57427 (just test) | License | MIT This is a test for #57433 Commits ------- 2fc8789 [Serializer] Check if exception message in test is correct
Member
|
Thank you @xabbuh. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.