[FrameworkBundle] Normalize workflow places separately#61596
Merged
nicolas-grekas merged 1 commit intoSep 8, 2025
Conversation
4009e69 to
5121921
Compare
Contributor
Author
|
It seems both the reviewer and milestone are not removed by @carsonbot after the target branch is changed. |
5121921 to
032000e
Compare
032000e to
eddc6a6
Compare
nicolas-grekas
approved these changes
Sep 8, 2025
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
I've simplified the code and removed strict types, which we don't use on this repo.
Member
|
Thank you @KevinVanSonsbeek. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 16, 2025
…sitions' from/to configs (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Perform-no-deep-merging on workflow transitions' from/to configs | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Similar to #61596 but for transitions. Also replaces #57873 per `@stof`'s comment at #57873 (comment) Commits ------- 66fff01 [FrameworkBundle] Perform-no-deep-merging on workflow transitions' from/to configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten the places
beforeNormalizationcallback, to normalize the defined places one by one. Rather than asserting behavior based on only the first item in the passed array.This way it is possible to combine places in both the "simplistic" and non simplistic format for 1 workflow.