Add GitHub Actions tips to readme.md#378
Merged
Merged
Conversation
The tip should lay out how to correctly configure a step to deploy an application via Github Actions. See issue tschaub#345 for more details
The hard-coded repository name can be replaced with the use of the GITHUB_REPOSITORY environmental variable available to the runner by default. The GitHub Actions tip has been updated to reflect this feature.
When executing the gh-pages command via a script defined inside the packages.json file, it requires the addition of an `--` parameter to properly pass the user information into the `gh-pages` command. A new example has been added reflecting that advice. This commit also includes minor formatting fixes and improvements the the existing GitHub Actions example.
Add GitHub Action tip for both named and unnamed commands
|
Thank you for f67964d |
Nirzak
approved these changes
Apr 5, 2021
tschaub
approved these changes
May 7, 2021
Owner
|
Thanks for the contribution, @mickelsonmichael! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #368 for the full breakdown of this addition. Due to issues with a fork, that PR needed to be recreated to be properly updated.
The updates to the original PR include minor adjustments to the URL when defining the step and some minor formatting improvements, as well as the addition of a section describing how to use named scripts inside the Action(s).