perf: migrate unplugins to oxc-walker#663
Merged
Merged
Conversation
d4f8855 to
7bae010
Compare
Replace legacy AST tooling (estree-walker, unplugin-ast, acorn-loose) with oxc-walker across addons, react, and solid-js packages. - addons: UseSeoMetaTransform now uses parseSync + walk instead of this.parse() + estree-walker - addons: TreeshakeServerComposables now uses parseSync + walk + MagicString instead of unplugin-ast - react/solid-js: streaming plugins use walk() instead of Visitor pattern with proper function stack context tracking Drops deps: estree-walker, unplugin-ast, @babel/types, @types/estree, acorn-loose
7bae010 to
b06f768
Compare
- Replace `findStaticImports` (mlly) with `parseAndWalk` (oxc-walker) across Vue, React, Solid, Svelte - Use Vite native `transform.filter` for file extension filtering via `createStreamingPlugin` - Remove `mlly` from all framework package dependencies and build externals
…mlly catalog TS narrowed existingImport to never since it was mutated inside parseAndWalk callback. Use explicit type assertion to break the narrowing.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #620
❓ Type of change
📚 Description
Replaces legacy AST tooling (
estree-walker,unplugin-ast,acorn-loose) withoxc-walkeracross all unplugin transforms, unifying on a single parser/walker stack.addons:
UseSeoMetaTransform—parseSync+walkreplacesthis.parse()+estree-walkerTreeshakeServerComposables—parseSync+walk+MagicStringreplacesunplugin-ast(babel-based)react/solid-js:
walk()with function stack context tracking instead ofoxc-parser'sVisitorpatternDeps removed:
estree-walker,unplugin-ast,@babel/types,@types/estree,acorn-looseDeps added:
oxc-walker(catalog)