fix(unhead): deduplicate matching tags inside same render cycle#668
Merged
fix(unhead): deduplicate matching tags inside same render cycle#668
Conversation
script[src] and link[href] tags across entries
Contributor
Bundle Size Analysis
|
…ntries Tags without an explicit dedup key (like `script[src]` and `link[href]`) were keyed by their unique position index in `dedupeTags()`, meaning identical tags from separate entries were never deduplicated. Now falls back to `hashTag()` (content-based hash) instead of position, so identical tags collide and deduplicate. The hash is precomputed during tag normalization and cached on `_h` to avoid recomputation in the DOM renderer. Closes #666
3704c23 to
0eea994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #666
❓ Type of change
📚 Description
Tags without an explicit dedup key (
script[src],link[href]) were keyed by their unique position index during tag resolution, so identical tags from separate entries were never deduplicated within the same render cycle.Now falls back to
hashTag()(content-based hash) instead of position index, so matching tags collide and deduplicate correctly. The hash is precomputed during normalization and cached on_hto avoid recomputation in the DOM renderer.