fix: use map instead of plain object for injection usage records (#496)

KazariEX · antfu · web-flow · commit b2f99244414a · 2026-02-27T10:20:57.000+09:00
* fix: use map instead of plain object for injection usage records

* test: add

* add `injections` and deprecate `injectionUsage`

* chore: update

* chore: update

---------

Co-authored-by: Anthony Fu &lt;github@antfu.me&gt;
diff --git a/src/context.ts b/src/context.ts
@@ -64,10 +64,13 @@ export function createUnimport(opts: Partial<UnimportOptions>): Unimport {
     const metadata = ctx.getMetadata()
     if (metadata) {
       result.imports.forEach((i) => {
-        metadata.injectionUsage[i.name] = metadata.injectionUsage[i.name] || { import: i, count: 0, moduleIds: [] }
-        metadata.injectionUsage[i.name].count++
-        if (id && !metadata.injectionUsage[i.name].moduleIds.includes(id))
-          metadata.injectionUsage[i.name].moduleIds.push(id)
+        let record = metadata.injectionsUsageMap.get(i.name)
+        if (!record) {
+          metadata.injectionsUsageMap.set(i.name, record = { import: i, count: 0, moduleIds: [] })
+        }
+        record.count++
+        if (id && !record.moduleIds.includes(id))
+          record.moduleIds.push(id)
       })
     }
 
@@ -119,7 +122,13 @@ function createInternalContext(opts: Partial<UnimportOptions>) {
 
   if (opts.collectMeta) {
     metadata = {
-      injectionUsage: {},
+      injectionsUsageMap: new Map(),
+      get injectionUsage() {
+        // eslint-disable-next-line unicorn/error-message
+        const stack = new Error().stack
+        console.warn('[unimport] `injectionUsage` is deprecated, use `injectionsUsageMap` instead', stack)
+        return Object.fromEntries(this.injectionsUsageMap)
+      },
     }
   }
 
diff --git a/src/types.ts b/src/types.ts
@@ -153,7 +153,11 @@ export interface InjectionUsageRecord {
 }
 
 export interface UnimportMeta {
-  injectionUsage: Record<string, InjectionUsageRecord>
+  injectionsUsageMap: Map<string, InjectionUsageRecord>
+  /**
+   * @deprecated use `injectionsUsageMap` instead
+   */
+  get injectionUsage(): Record<string, InjectionUsageRecord>
 }
 
 export interface AddonsOptions {
diff --git a/test/inject.test.ts b/test/inject.test.ts
@@ -29,6 +29,7 @@ describe('inject import', () => {
         { name: 'import3', from: 'specifier3' },
         { name: 'import4', from: 'specifier4' },
         { name: 'foo', as: 'import5', from: 'specifier5' },
+        { name: 'toString', from: 'specifier6' },
         { name: 'import10', from: 'specifier10' },
       ],
       collectMeta: true,
@@ -37,6 +38,7 @@ describe('inject import', () => {
     await ctx.injectImports('console.log(import1())', 'foo')
     await ctx.injectImports('console.log(import2())', 'bar')
     await ctx.injectImports('console.log(import1())', 'gar')
+    await ctx.injectImports('console.log(toString())')
 
     expect(ctx.getMetadata()).toMatchInlineSnapshot(`
       {
@@ -64,6 +66,49 @@ describe('inject import', () => {
               "bar",
             ],
           },
+          "toString": {
+            "count": 1,
+            "import": {
+              "as": "toString",
+              "from": "specifier6",
+              "name": "toString",
+            },
+            "moduleIds": [],
+          },
+        },
+        "injectionsUsageMap": Map {
+          "import1" => {
+            "count": 3,
+            "import": {
+              "as": "import1",
+              "from": "specifier1",
+              "name": "import1",
+            },
+            "moduleIds": [
+              "foo",
+              "gar",
+            ],
+          },
+          "import2" => {
+            "count": 1,
+            "import": {
+              "as": "import2",
+              "from": "specifier2",
+              "name": "import2",
+            },
+            "moduleIds": [
+              "bar",
+            ],
+          },
+          "toString" => {
+            "count": 1,
+            "import": {
+              "as": "toString",
+              "from": "specifier6",
+              "name": "toString",
+            },
+            "moduleIds": [],
+          },
         },
       }
     `)

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,11 @@ export interface InjectionUsageRecord {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`export interface UnimportMeta {`
`156`		`- injectionUsage: Record<string, InjectionUsageRecord>`
	`156`	`+ injectionsUsageMap: Map<string, InjectionUsageRecord>`
	`157`	`+ /**`
	`158`	+ * @deprecated use `injectionsUsageMap` instead
	`159`	`+ */`
	`160`	`+ get injectionUsage(): Record<string, InjectionUsageRecord>`
`157`	`161`	`}`
`158`	`162`
`159`	`163`	`export interface AddonsOptions {`