Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[backport] Turbopack: throw large static metadata error earlier #83816

Merged
mischnic merged 1 commit into
next-15-5from
mischnic/backport-d6794f4
Sep 17, 2025
Merged

[backport] Turbopack: throw large static metadata error earlier #83816
mischnic merged 1 commit into
next-15-5from
mischnic/backport-d6794f4

Conversation

@mischnic
Copy link
Copy Markdown
Member

@mischnic mischnic commented Sep 15, 2025 •
edited by padmaia
Loading

Backport #82939
Needed for #83806

Closes PACK-5478

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. labels Sep 15, 2025
@mischnic mischnic requested a review from a team September 15, 2025 18:52
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 15, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #83816 will degrade performances by 7.37%

Comparing mischnic/backport-d6794f4 (4af502f) with canary (3e5c8ef)1

🎉 Hooray! codspeed-rust just leveled up to 2.10.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 9 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ build[date-fns-all] 2.2 s 2.3 s -5.97%
❌ build[date-fns-single] 1.3 s 1.4 s -5.29%
❌ build[framer-motion-all] 3 s 3.2 s -7.37%
❌ build[framer-motion-single] 2.1 s 2.3 s -6.64%
❌ build[joy] 2 s 2.1 s -5.72%
❌ build[lucide-react-all] 8.6 s 9.2 s -7.32%
❌ build[lucide-react-single] 866.5 ms 909.5 ms -4.72%
❌ build[mui] 3 s 3.2 s -6.18%
❌ build[shiki] 5.9 s 6.1 s -3.76%

Footnotes

  1. No successful run was found on next-15-5 (1f6ea09) during the generation of this report, so canary (3e5c8ef) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@mischnic mischnic force-pushed the mischnic/backport-d6794f4 branch from 7433c72 to b93e617 Compare September 16, 2025 13:49
@mischnic
Turbopack: throw large static metadata error earlier (#82939)
4af502f 
Throw it during bundling, as opposed to at runtime.

This circumnavigates a panic in Turbopack when inlining a 40mb string into a JS module.
@mischnic mischnic force-pushed the mischnic/backport-d6794f4 branch from b93e617 to 4af502f Compare September 17, 2025 12:47
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Sep 17, 2025 •
edited
Loading

Tests Passed

@mischnic mischnic merged commit 050bdf1 into next-15-5 Sep 17, 2025
264 of 269 checks passed
@mischnic mischnic deleted the mischnic/backport-d6794f4 branch September 17, 2025 17:02
@github-actions github-actions Bot added the locked label Oct 2, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mischnic @ijjk @sokra @timneutkens