Codestin Search App

Jinjiang · 2025-01-31T07:50:32Z

Description

Fix the issue when there is no package name in package.json.

which causes errors like below:

[vite:css-post] Cannot read properties of undefined (reading '0')
[vite:css-post] Cannot read properties of undefined (reading '0')
    at getPkgName (/.../node_modules/vite/dist/node/chunks/dep-M1IYMR16.js:10488:14)
    at resolveLibCssFilename (/.../node_modules/vite/dist/node/chunks/dep-M1IYMR16.js:50127:30)

patak-cat · 2025-01-31T14:00:38Z

Why does the package.json doesn't have a name? It is required:

A package.json file must contain "name" and "version" fields.

Maybe we should improve the error instead saying that the package.json is malformed?

silverwind · 2025-01-31T14:21:08Z

name and version may be required in the docs, but as far as the npm client is concerned {} is a valid package.json, so I suggest to treat is gracefully.

I think those requirements are only enforced for published packages.

sapphi-red · 2025-02-03T03:04:53Z

I think this part needs to be fixed as well.

vite/packages/vite/src/node/build.ts

Lines 922 to 932 in e8c783f

const packageJson = findNearestPackageData(root, packageCache)?.data

const name =

libOptions.fileName ||

(packageJson && typeof libOptions.entry === 'string'

? getPkgName(packageJson.name)

: entryName)

if (!name)

throw new Error(

'Name in package.json is required if option "build.lib.fileName" is not provided.',

)

@sapphi-red Just confirm: I saw several test cases particular on packages/noname. Do you think it should be updated to packages/name as well? Thanks.

https://github.com/vitejs/vite/blob/main/packages/vite/src/node/__tests__/build.spec.ts

I think it should be packages/noname as-is, but the resolved name should be updated so that we test the fallback behavior.

Test case updated. I also added an additional packages/vite/src/node/__tests__/packages/package.json to catch the resolver for noname. Please take a look. 🙏

sapphi-red · 2025-02-03T03:05:03Z

  const packageJson = findNearestPackageData(root, packageCache)?.data
-  const name = packageJson ? getPkgName(packageJson.name) : undefined
+  const name =
+    packageJson && packageJson.name ? getPkgName(packageJson.name) : undefined


We have findNearestMainPackageData function that skips the package.json without name field. I think swapping findNearestPackageData with it matches the users expectations.

vite/packages/vite/src/node/packages.ts

Lines 161 to 162 in e8c783f

// Finds the nearest package.json with a `name` field

export function findNearestMainPackageData(

sapphi-red · 2025-02-03T03:17:40Z

Sometimes there're nested package.jsons inside a package. This is often used to map require('pkg/dir') to somewhere else (e.g. pkg/dir/dir.js). We don't need this anymore as most bundlers support exports field though.
https://cdn.jsdelivr.net/npm/[email protected]/button/package.json
The other case I saw was placing package.json only with { "type": "commonjs" } in a directory so that all files in that directory is treated as CJS.

sapphi-red

Thanks!

Jinjiang · 2025-04-11T07:50:53Z

Just FYI: I've found the root cause of this error is that I didn't set build.lib.cssFileName in my project properly, which is a new one and required if there is no name specieid in package.json in Vite v6.

…s#19324)

Jinjiang added 2 commits January 31, 2025 15:48

fix: avoid packageJson without name in resolveLibCssFilename

ae06721

Update css.ts

6f1e744

patak-cat previously approved these changes Jan 31, 2025

View reviewed changes

patak-cat added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 31, 2025

sapphi-red reviewed Feb 3, 2025

View reviewed changes

fix: reuse findNearestMainPackageData at more places

635521f

Jinjiang dismissed patak-cat’s stale review via 635521f February 4, 2025 02:49

Jinjiang added 2 commits February 4, 2025 15:46

fix: tests for new behavior of resolveLibFilename()

3084ac9

chore: update pnpm lock file

75b88f3

sapphi-red reviewed Feb 4, 2025

View reviewed changes

Comment thread packages/vite/src/node/__tests__/packages/module/package.json

sapphi-red approved these changes Feb 4, 2025

View reviewed changes

sapphi-red changed the title ~~fix: avoid packageJson without name in resolveLibCssFilename~~ fix: avoid packageJson without name in resolveLibCssFilename Feb 4, 2025

patak-cat merged commit f183bdf into vitejs:main Feb 4, 2025

Jinjiang deleted the patch-1 branch February 4, 2025 09:39

moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025

fix: avoid packageJson without name in resolveLibCssFilename (vitej…

c02ca15

…s#19324)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: avoid packageJson without name in `resolveLibCssFilename`#19324

fix: avoid packageJson without name in `resolveLibCssFilename`#19324
patak-cat merged 5 commits into
vitejs:mainfrom
Jinjiang:patch-1

Jinjiang commented Jan 31, 2025

Uh oh!

patak-cat commented Jan 31, 2025

Uh oh!

silverwind commented Jan 31, 2025 •

edited

Loading

Uh oh!

sapphi-red Feb 3, 2025

Uh oh!

Jinjiang Feb 4, 2025 •

edited

Loading

Uh oh!

sapphi-red Feb 4, 2025

Uh oh!

Jinjiang Feb 4, 2025

Uh oh!

sapphi-red Feb 3, 2025

Uh oh!

sapphi-red commented Feb 3, 2025 •

edited

Loading

Uh oh!

sapphi-red left a comment

Uh oh!

Uh oh!

Jinjiang commented Apr 11, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const packageJson = findNearestPackageData(root, packageCache)?.data
	const name =
	libOptions.fileName \|\|
	(packageJson && typeof libOptions.entry === 'string'
	? getPkgName(packageJson.name)
	: entryName)

	if (!name)
	throw new Error(
	'Name in package.json is required if option "build.lib.fileName" is not provided.',
	)

	// Finds the nearest package.json with a `name` field
	export function findNearestMainPackageData(

Uh oh!

Conversation

Jinjiang commented Jan 31, 2025

Description

Uh oh!

patak-cat commented Jan 31, 2025

Uh oh!

silverwind commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

Jinjiang Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sapphi-red Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Jinjiang Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

sapphi-red Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

sapphi-red commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jinjiang commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

silverwind commented Jan 31, 2025 •

edited

Loading

Jinjiang Feb 4, 2025 •

edited

Loading

sapphi-red commented Feb 3, 2025 •

edited

Loading

Jinjiang commented Apr 11, 2025 •

edited

Loading