perf(logger): calculate trace only when needed #10683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10683 will not alter performanceComparing 🎉 Hooray!
|
ahabhgk
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In large projects, loaders such as sass-loader or less-loader may emit a lot of warnings. In this case, Rspack will incur significant performance overhead in order to calculate the Error trace.
In an internal project, Less 4.3.0 emits 350,000 warnings. This PR changes the calculation of traces to on-demand, which can reduce the build time of the project from 40s+ to 20s.
Checklist