Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: disableElementImplicitWait not working when defined too early#15186

Merged
dprevost-LMI merged 5 commits into
webdriverio:mainfrom
dprevost-LMI:fix-disableElementImplicitWait-not-fully-working
Apr 8, 2026
Merged

fix: disableElementImplicitWait not working when defined too early#15186
dprevost-LMI merged 5 commits into
webdriverio:mainfrom
dprevost-LMI:fix-disableElementImplicitWait-not-fully-working

Conversation

@dprevost-LMI
Copy link
Copy Markdown
Contributor

@dprevost-LMI dprevost-LMI commented Apr 7, 2026 •
edited
Loading

Proposed changes

Fixes #15185

When registering an element custom command before the session starts, if the option object was used, as in { attachToElement: true }, it was not processed correctly, since only the legacy behaviour was handled.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@dprevost-LMI dprevost-LMI added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 7, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 7, 2026 •
edited
Loading

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@15186

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@15186

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@15186

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@15186

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@15186

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@15186

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@15186

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@15186

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@15186

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@15186

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@15186

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@15186

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@15186

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@15186

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@15186

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@15186

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@15186

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@15186

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@15186

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@15186

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@15186

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@15186

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@15186

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@15186

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@15186

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@15186

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@15186

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@15186

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@15186

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@15186

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@15186

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@15186

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@15186

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@15186

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@15186

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@15186

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@15186

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@15186

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@15186

commit: ef10e4e

@dprevost-LMI dprevost-LMI force-pushed the fix-disableElementImplicitWait-not-fully-working branch from 8cb5e1e to 103a4c8 Compare April 7, 2026 15:19
@dprevost-LMI dprevost-LMI force-pushed the fix-disableElementImplicitWait-not-fully-working branch from d977286 to ef10e4e Compare April 8, 2026 01:13
@dprevost-LMI dprevost-LMI marked this pull request as ready for review April 8, 2026 01:40
@dprevost-LMI dprevost-LMI merged commit 3ecae26 into webdriverio:main Apr 8, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: addCommand with disableElementImplicitWait loses option when registered before the session starts

1 participant

@dprevost-LMI