yarn.config.cjs support#864
Merged
Merged
Conversation
webpro
reviewed
Dec 2, 2024
| cwd, | ||
| }); | ||
|
|
||
| assert(issues.files.size === 0); |
Member
There was a problem hiding this comment.
Just saying, baseCounters contains files: 0 which is essentially the same assertion (no need to change though).
|
|
||
| // https://yarnpkg.com/features/constraints | ||
|
|
||
| const title = 'yarn'; |
Member
There was a problem hiding this comment.
The only nitpick I have is that Yarn seems to be the official spelling (title cased).
commit: |
webpro
reviewed
Dec 2, 2024
|
|
||
| const enablers = 'This plugin is enabled when a `yarn.lock` file is found in the root folder.'; | ||
|
|
||
| const isEnabled: IsPluginEnabled = async ({ cwd }) => (await _glob({ cwd, patterns: ['yarn.lock'] })).length > 0; |
Member
There was a problem hiding this comment.
There's _firstGlob for this, any chance we could use that? Example: https://github.com/webpro-nl/knip/blob/main/packages/knip/src/plugins/github-actions/index.ts#L13-L14 (probably should move into a nice helper but we could consider this in another PR)
Member
|
Thanks, Jeong! |
Member
|
🚀 This pull request is included in v5.39.0. See Release 5.39.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #597