Track Angular environment files as entry points#868
Merged
Conversation
commit: |
Member
|
You're not leaving much on the table to complain about, this is great |
Member
|
🚀 This pull request is included in v5.39.0. See Release 5.39.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks Angular environment specific files as entry points.
Takes into account:
src/replaceWithinstead ofreplace/with).configurations. As they're technically correct and work. However, it's not a common use case. The purpose of environment files is to apply different ones depending on the configuration, not apply them for all cases (hence part of the builder options). Also those aren't used if a configuration specifies somefileReplacements.