Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Track Angular environment files as entry points#868

Merged
webpro merged 1 commit into
webpro-nl:mainfrom
davidlj95:track-angular-env-files
Dec 2, 2024
Merged

Track Angular environment files as entry points#868
webpro merged 1 commit into
webpro-nl:mainfrom
davidlj95:track-angular-env-files

Conversation

@davidlj95
Copy link
Copy Markdown
Contributor

Tracks Angular environment specific files as entry points.

Takes into account:

  • If file replacements are part of a production configuration or not to add them as production entries or not.
  • Previous syntax for Webpack-based browser application builder (src/replaceWith instead of replace/with).
  • File replacements out of configurations. As they're technically correct and work. However, it's not a common use case. The purpose of environment files is to apply different ones depending on the configuration, not apply them for all cases (hence part of the builder options). Also those aren't used if a configuration specifies some fileReplacements.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Dec 2, 2024

Open in Stackblitz

npm i https://pkg.pr.new/knip@868

commit: 8bbfb72

@webpro webpro merged commit 7950bf3 into webpro-nl:main Dec 2, 2024
@webpro
Copy link
Copy Markdown
Member

webpro commented Dec 2, 2024

You're not leaving much on the table to complain about, this is great

@webpro
Copy link
Copy Markdown
Member

webpro commented Dec 2, 2024

🚀 This pull request is included in v5.39.0. See Release 5.39.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@davidlj95 davidlj95 deleted the track-angular-env-files branch December 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants