fix: ensure augmentWorkspace honors tsConfig rootDir#933
Merged
Conversation
commit: |
Member
|
Thanks @rmunch! Simply by looking at the logic/syntax I'm pretty sure you're right. The parentheses placement made no sense. |
Member
|
🚀 This pull request is included in v5.44.0. See Release 5.44.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes logic that has a bug due to incorrect parenthesis in a ternary. When a
rootDiris specified in tsconfig.json that has a value of something other than"src", therootDirconfig is not honored. In my case, I do have asrcdir, but it's unrelated to my TypeScript source which is located elsewhere (where myrootDirpoins to). Knip ends up forcing the workspacesrcDirvalue to"src"due to this bug combined with the presence of asrcdirectory.I attempted to add a test, but I'm not so familiar with the codebase and could not seem to exercise the right code paths 😞, but can give it another try if needed.