Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: show skip reason by default#941

Merged
henryiii merged 6 commits into
wntrblm:mainfrom
chirizxc:main
Apr 13, 2025
Merged

feat: show skip reason by default#941
henryiii merged 6 commits into
wntrblm:mainfrom
chirizxc:main

Conversation

@chirizxc

Copy link
Copy Markdown
Contributor

/closes #940

@henryiii

Copy link
Copy Markdown
Collaborator

I don't know if this needs to be a flag. I think something like this would likely be fine:

-        result.log(f"* {name}: {status}")
+        if result.status is Status.SKIPPED and result.reason:
+            result.log(f"* {name}: {status} ({result.reason})")
+        else:
+            result.log(f"* {name}: {status}")

@chirizxc

chirizxc commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

I don't know if this needs to be a flag. I think something like this would likely be fine:

-        result.log(f"* {name}: {status}")
+        if result.status is Status.SKIPPED and result.reason:
+            result.log(f"* {name}: {status} ({result.reason})")
+        else:
+            result.log(f"* {name}: {status}")

maybe we can make this behaviour by default?

@henryiii

Copy link
Copy Markdown
Collaborator

That's what I meant. If a reason is set, we could just always show it.

@chirizxc chirizxc changed the title feat: add --skip-summary-details flag feat: show skip reason by default Mar 25, 2025
@chirizxc

Copy link
Copy Markdown
Contributor Author

idk why coverage failed, but here is successful: https://github.com/chirizxc/nox/actions/runs/14065702085/job/39389829080

@henryiii henryiii merged commit 4e7f644 into wntrblm:main Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add option to display reason for skipped sessions in the summary

2 participants