fix: 🐛 use isser instead of constructor to apply autorefresh setting to Factory (#998)

ttskch · web-flow · commit 9489e839ff3c · 2025-10-08T10:47:17.000+02:00
diff --git a/src/Persistence/PersistentObjectFactory.php b/src/Persistence/PersistentObjectFactory.php
@@ -51,14 +51,7 @@ abstract class PersistentObjectFactory extends ObjectFactory
 
     private bool $isRootFactory = true;
 
-    private bool $autorefreshEnabled = false;
-
-    public function __construct()
-    {
-        parent::__construct();
-
-        $this->autorefreshEnabled = Configuration::autoRefreshWithLazyObjectsIsEnabled();
-    }
+    private bool|null $autorefreshEnabled = null;
 
     /**
      * @phpstan-param mixed|Parameters $criteriaOrId
@@ -525,7 +518,7 @@ static function(object $object, array $parameters, PersistentObjectFactory $fact
                     }
 
                     if (
-                        $factoryUsed->autorefreshEnabled
+                        $factoryUsed->isAutorefreshEnabled()
                         && !$factoryUsed instanceof PersistentProxyObjectFactory
                     ) {
                         Configuration::instance()->persistedObjectsTracker?->add($object);
@@ -545,6 +538,11 @@ static function(object $object, array $parameters, PersistentObjectFactory $fact
         ;
     }
 
+    private function isAutorefreshEnabled(): bool
+    {
+        return $this->autorefreshEnabled ??= Configuration::autoRefreshWithLazyObjectsIsEnabled();
+    }
+
     private function throwIfCannotCreateObject(): void
     {
         $configuration = Configuration::instance();
