minor: remove useless Factories trait (#1067)

nikophil · nikophil · commit 9aaf683f374e · 2026-02-04T10:12:39.000+01:00
diff --git a/src/PHPUnit/DisplayFakerSeedOnApplicationFinished.php b/src/PHPUnit/DisplayFakerSeedOnApplicationFinished.php
@@ -20,14 +20,14 @@
  * @internal
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  */
-final class DisplayFakerSeedOnTestSuiteFinished implements Event\TestRunner\FinishedSubscriber
+final class DisplayFakerSeedOnApplicationFinished implements Event\Application\FinishedSubscriber
 {
-    public function notify(Event\TestRunner\Finished $event): void
+    public function notify(Event\Application\Finished $event): void
     {
         $fakerSeed = FakerAdapter::fakerSeed();
 
         if (null !== $fakerSeed) {
-            echo "\n\nFaker seed: ".$fakerSeed; // @phpstan-ignore ekinoBannedCode.expression
+            echo "\nFaker seed used: {$fakerSeed}\n"; // @phpstan-ignore ekinoBannedCode.expression
         }
     }
 }
diff --git a/src/PHPUnit/FoundryExtension.php b/src/PHPUnit/FoundryExtension.php
@@ -57,7 +57,7 @@ public function bootstrap(
                     new TriggerDataProviderPersistenceOnTestPrepared(),
                 ],
                 Event\Test\Finished::class => [new ShutdownFoundryOnTestFinished()],
-                Event\TestRunner\Finished::class => [new DisplayFakerSeedOnTestSuiteFinished()],
+                Event\TestRunner\Finished::class => [new DisplayFakerSeedOnApplicationFinished()],
             ];
 
             $subscribers = \array_merge(...\array_values($subscribers));
diff --git a/tests/Integration/Attribute/WithStory/ParentClassWithStoryAttributeTestCase.php b/tests/Integration/Attribute/WithStory/ParentClassWithStoryAttributeTestCase.php
@@ -15,7 +15,6 @@
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Attribute\WithStory;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Stories\EntityStory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
@@ -26,5 +25,5 @@
 #[WithStory(EntityStory::class)]
 abstract class ParentClassWithStoryAttributeTestCase extends KernelTestCase
 {
-    use Factories, RequiresORM, ResetDatabase;
+    use RequiresORM, ResetDatabase;
 }
diff --git a/tests/Integration/Attribute/WithStory/WithStoryOnClassTest.php b/tests/Integration/Attribute/WithStory/WithStoryOnClassTest.php
@@ -19,7 +19,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Attribute\WithStory;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Fixture\Stories\EntityPoolStory;
@@ -35,7 +34,7 @@
 #[WithStory(EntityStory::class)]
 final class WithStoryOnClassTest extends KernelTestCase
 {
-    use Factories, RequiresORM, ResetDatabase;
+    use RequiresORM, ResetDatabase;
 
     #[Test]
     public function can_use_story_in_attribute(): void
diff --git a/tests/Integration/Attribute/WithStory/WithStoryOnMethodTest.php b/tests/Integration/Attribute/WithStory/WithStoryOnMethodTest.php
@@ -19,7 +19,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Attribute\WithStory;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Fixture\Stories\EntityPoolStory;
@@ -35,7 +34,7 @@
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 final class WithStoryOnMethodTest extends KernelTestCase
 {
-    use Factories, RequiresORM, ResetDatabase;
+    use RequiresORM, ResetDatabase;
 
     #[Test]
     #[WithStory(EntityStory::class)]
diff --git a/tests/Integration/DataProvider/DataProviderForServiceFactoryInKernelTestCaseTest.php b/tests/Integration/DataProvider/DataProviderForServiceFactoryInKernelTestCaseTest.php
@@ -20,7 +20,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Configuration;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Object1Factory;
 use Zenstruck\Foundry\Tests\Fixture\Object1;
 
@@ -34,8 +33,6 @@
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 final class DataProviderForServiceFactoryInKernelTestCaseTest extends KernelTestCase
 {
-    use Factories;
-
     #[Test]
     #[DataProvider('createObjectFromServiceFactoryInDataProvider')]
     public function it_can_create_one_object_in_data_provider(?Object1 $providedData, string $expected): void
diff --git a/tests/Integration/DataProvider/DataProviderInUnitTest.php b/tests/Integration/DataProvider/DataProviderInUnitTest.php
@@ -21,7 +21,6 @@
 use PHPUnit\Framework\TestCase;
 use Zenstruck\Foundry\Persistence\ProxyGenerator;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Tests\Fixture\Entity\GenericEntity;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericProxyEntityFactory;
@@ -41,8 +40,6 @@
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 final class DataProviderInUnitTest extends TestCase
 {
-    use Factories;
-
     #[Test]
     #[DataProvider('createObjectWithObjectFactoryInDataProvider')]
     public function assert_it_can_create_object_with_object_factory_in_data_provider(mixed $providedData, mixed $expectedData): void
diff --git a/tests/Integration/DataProvider/DataProviderWithInMemoryTest.php b/tests/Integration/DataProvider/DataProviderWithInMemoryTest.php
@@ -26,7 +26,6 @@
 use Zenstruck\Foundry\Persistence\PersistentObjectFactory;
 use Zenstruck\Foundry\Persistence\ProxyGenerator;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Entity\Contact;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\Contact\ContactFactory;
@@ -43,7 +42,6 @@
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 final class DataProviderWithInMemoryTest extends KernelTestCase
 {
-    use Factories;
     use RequiresORM; // needed to use the entity manager
     use ResetDatabase;
 
diff --git a/tests/Integration/DataProvider/DataProviderWithPersistentDocumentFactoryTest.php b/tests/Integration/DataProvider/DataProviderWithPersistentDocumentFactoryTest.php
@@ -20,22 +20,20 @@
 use Zenstruck\Foundry\Tests\Fixture\Document\DocumentWithReadonly;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Document\GenericDocumentFactory;
 use Zenstruck\Foundry\Tests\Fixture\Model\Embeddable;
-use Zenstruck\Foundry\Tests\Integration\RequiresMongo;
 
 use function Zenstruck\Foundry\Persistence\persistent_factory;
 
 /**
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  * @requires PHPUnit >=12
  */
-#[RequiresPhpunit('>=12')]
 #[RequiresPhp('>=8.4')]
+#[RequiresPhpunit('>=12')]
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 #[RequiresEnvironmentVariable('USE_PHP_84_LAZY_OBJECTS', '1')]
+#[RequiresEnvironmentVariable('MONGO_URL')]
 final class DataProviderWithPersistentDocumentFactoryTest extends DataProviderWithPersistentFactoryTestCase
 {
-    use RequiresMongo;
-
     protected static function factory(): PersistentObjectFactory
     {
         return GenericDocumentFactory::new();
diff --git a/tests/Integration/DataProvider/DataProviderWithPersistentEntityFactoryTest.php b/tests/Integration/DataProvider/DataProviderWithPersistentEntityFactoryTest.php
@@ -20,22 +20,20 @@
 use Zenstruck\Foundry\Tests\Fixture\Entity\EdgeCases\EntityWithReadonly\EntityWithReadonly;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Fixture\Model\Embeddable;
-use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
 use function Zenstruck\Foundry\Persistence\persistent_factory;
 
 /**
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  * @requires PHPUnit >=12
  */
-#[RequiresPhpunit('>=12')]
 #[RequiresPhp('>=8.4')]
+#[RequiresPhpunit('>=12')]
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 #[RequiresEnvironmentVariable('USE_PHP_84_LAZY_OBJECTS', '1')]
+#[RequiresEnvironmentVariable('DATABASE_URL')]
 final class DataProviderWithPersistentEntityFactoryTest extends DataProviderWithPersistentFactoryTestCase
 {
-    use RequiresORM;
-
     protected static function factory(): PersistentObjectFactory
     {
         return GenericEntityFactory::new();
diff --git a/tests/Integration/DataProvider/DataProviderWithProxyPersistentEntityFactoryTest.php b/tests/Integration/DataProvider/DataProviderWithProxyPersistentEntityFactoryTest.php
@@ -37,15 +37,14 @@
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  * @requires PHPUnit >=12
  */
+#[IgnoreDeprecations]
 #[RequiresPhpunit('>=12')]
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 #[RequiresEnvironmentVariable('USE_PHP_84_LAZY_OBJECTS', '0')]
-#[IgnoreDeprecations]
+#[RequiresEnvironmentVariable('DATABASE_URL')]
 #[RequiresMethod(\Symfony\Component\VarExporter\LazyProxyTrait::class, 'createLazyProxy')]
 final class DataProviderWithProxyPersistentEntityFactoryTest extends DataProviderWithPersistentFactoryTestCase
 {
-    use RequiresORM;
-
     #[Test]
     #[DataProvider('createOneProxyObjectInDataProvider')]
     public function assert_provided_data_is_proxy(?GenericModel $providedData): void
diff --git a/tests/Integration/Faker/FakerSeedDoNotConflictWithDataProviderTest.php b/tests/Integration/Faker/FakerSeedDoNotConflictWithDataProviderTest.php
@@ -14,31 +14,31 @@
 namespace Zenstruck\Foundry\Tests\Integration\Faker;
 
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresEnvironmentVariable;
 use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\RequiresPhpunit;
 use PHPUnit\Framework\Attributes\RequiresPhpunitExtension;
 use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\FakerAdapter;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Entity\WithUniqueColumn;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\WithUniqueColumn\WithUniqueColumnFactory;
-use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
 use function Zenstruck\Foundry\faker;
 
 /**
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  * @requires PHPUnit >=12.0
  */
+#[RequiresPhp('^8.4')]
 #[RequiresPhpunit('>=12.0')]
 #[RequiresPhpunitExtension(FoundryExtension::class)]
-#[RequiresPhp('^8.4')]
+#[RequiresEnvironmentVariable('DATABASE_URL')]
 final class FakerSeedDoNotConflictWithDataProviderTest extends KernelTestCase
 {
-    use Factories, RequiresORM, ResetDatabase;
+    use ResetDatabase;
 
     #[Test]
     #[DataProvider('provideObject')]
diff --git a/tests/Integration/InMemory/DoctrineInMemoryDecoratorTest.php b/tests/Integration/InMemory/DoctrineInMemoryDecoratorTest.php
@@ -43,8 +43,6 @@
 #[AsInMemoryTest]
 final class DoctrineInMemoryDecoratorTest extends KernelTestCase
 {
-    use Factories;
-
     /**
      * @test
      */
diff --git a/tests/Integration/InMemory/InMemoryAttributeOnMethodTest.php b/tests/Integration/InMemory/InMemoryAttributeOnMethodTest.php
@@ -20,7 +20,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\InMemory\AsInMemoryTest;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
-use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
 use Zenstruck\Foundry\Tests\Fixture\Entity\Address;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\Address\AddressFactory;
@@ -34,7 +33,6 @@
 #[RequiresPhpunitExtension(FoundryExtension::class)]
 final class InMemoryAttributeOnMethodTest extends KernelTestCase
 {
-    use Factories;
     use RequiresORM;
     use ResetDatabase;
 
diff --git a/tests/Integration/Mongo/AutoRefreshTest.php b/tests/Integration/Mongo/AutoRefreshTest.php
@@ -22,20 +22,18 @@
 use Zenstruck\Foundry\Tests\Fixture\Document\GenericDocument;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Document\GenericDocumentFactory;
 use Zenstruck\Foundry\Tests\Integration\Persistence\AutoRefreshTestCase;
-use Zenstruck\Foundry\Tests\Integration\RequiresMongo;
 
 use function Zenstruck\Foundry\Persistence\persistent_factory;
 
 /**
  * @requires PHPUnit >=12
  */
+#[RequiresPhp('>= 8.4')]
 #[RequiresPhpunit('>=12')]
 #[RequiresEnvironmentVariable('USE_PHP_84_LAZY_OBJECTS', '1')]
-#[RequiresPhp('>= 8.4')]
+#[RequiresEnvironmentVariable('MONGO_URL')]
 final class AutoRefreshTest extends AutoRefreshTestCase
 {
-    use RequiresMongo;
-
     protected static function factory(): PersistentObjectFactory
     {
         return GenericDocumentFactory::new();
diff --git a/tests/Integration/ORM/AutoRefreshTest.php b/tests/Integration/ORM/AutoRefreshTest.php
@@ -36,7 +36,6 @@
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\Contact\ContactFactory;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Integration\Persistence\AutoRefreshTestCase;
-use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
 use function Zenstruck\Foundry\Persistence\assert_not_persisted;
 use function Zenstruck\Foundry\Persistence\assert_persisted;
@@ -47,12 +46,13 @@
 /**
  * @requires PHPUnit >=12
  */
+#[RequiresPhp('>= 8.4')]
 #[RequiresPhpunit('>=12')]
 #[RequiresEnvironmentVariable('USE_PHP_84_LAZY_OBJECTS', '1')]
-#[RequiresPhp('>= 8.4')]
+#[RequiresEnvironmentVariable('DATABASE_URL')]
 final class AutoRefreshTest extends AutoRefreshTestCase
 {
-    use ChangesEntityRelationshipCascadePersist, RequiresORM;
+    use ChangesEntityRelationshipCascadePersist;
 
     #[Test]
     public function tracker_keeps_reference_only_for_objects_in_current_scope(): void

Original file line number	Diff line number	Diff line change
`@@ -20,14 +20,14 @@`
`20`	`20`	`* @internal`
`21`	`21`	`* @author Nicolas PHILIPPE <[email protected]>`
`22`	`22`	`*/`
`23`		`-final class DisplayFakerSeedOnTestSuiteFinished implements Event\TestRunner\FinishedSubscriber`
	`23`	`+final class DisplayFakerSeedOnApplicationFinished implements Event\Application\FinishedSubscriber`
`24`	`24`	`{`
`25`		`- public function notify(Event\TestRunner\Finished $event): void`
	`25`	`+ public function notify(Event\Application\Finished $event): void`
`26`	`26`	`{`
`27`	`27`	`$fakerSeed = FakerAdapter::fakerSeed();`
`28`	`28`
`29`	`29`	`if (null !== $fakerSeed) {`
`30`		`- echo "\n\nFaker seed: ".$fakerSeed; // @phpstan-ignore ekinoBannedCode.expression`
	`30`	`+ echo "\nFaker seed used: {$fakerSeed}\n"; // @phpstan-ignore ekinoBannedCode.expression`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`
`16`	`16`	`use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;`
`17`	`17`	`use Zenstruck\Foundry\Attribute\WithStory;`
`18`		`-use Zenstruck\Foundry\Test\Factories;`
`19`	`18`	`use Zenstruck\Foundry\Test\ResetDatabase;`
`20`	`19`	`use Zenstruck\Foundry\Tests\Fixture\Stories\EntityStory;`
`21`	`20`	`use Zenstruck\Foundry\Tests\Integration\RequiresORM;`
`@@ -26,5 +25,5 @@`
`26`	`25`	`#[WithStory(EntityStory::class)]`
`27`	`26`	`abstract class ParentClassWithStoryAttributeTestCase extends KernelTestCase`
`28`	`27`	`{`
`29`		`- use Factories, RequiresORM, ResetDatabase;`
	`28`	`+ use RequiresORM, ResetDatabase;`
`30`	`29`	`}`