fix: Enhanced random method with additional safety check. (#991)

sofwar · web-flow · commit b4b2ffe469f4 · 2025-10-02T18:47:37.000+02:00
diff --git a/src/Persistence/RepositoryDecorator.php b/src/Persistence/RepositoryDecorator.php
@@ -199,7 +199,13 @@ public function random(array $criteria = []): object
             $offset = \random_int(0, $count - 1);
         }
 
-        return $this->findBy($criteria, limit: 1, offset: $offset)[0];
+        $result = $this->findBy($criteria, limit: 1, offset: $offset);
+
+        if (!\count($result)) {
+            throw new NotEnoughObjects(\sprintf('At least %d "%s" object(s) must have been persisted (%d persisted).', 1, $this->getClassName(), 0));
+        }
+
+        return $result[0];
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,13 @@ public function random(array $criteria = []): object`
`199`	`199`	`$offset = \random_int(0, $count - 1);`
`200`	`200`	`}`
`201`	`201`
`202`		`- return $this->findBy($criteria, limit: 1, offset: $offset)[0];`
	`202`	`+ $result = $this->findBy($criteria, limit: 1, offset: $offset);`
	`203`	`+`
	`204`	`+ if (!\count($result)) {`
	`205`	`+ throw new NotEnoughObjects(\sprintf('At least %d "%s" object(s) must have been persisted (%d persisted).', 1, $this->getClassName(), 0));`
	`206`	`+ }`
	`207`	`+`
	`208`	`+ return $result[0];`
`203`	`209`	`}`
`204`	`210`
`205`	`211`	`/**`