Improve phpdoc for non empty list#1037
Merged
Merged
Conversation
eff0984 to
ad55fac
Compare
Member
|
hi @VincentLanglet, I've rebased your PR in order to see if the CI is passing, but phpstan fails, seems related to your PR, could you fix it please? |
795abef to
64dda06
Compare
64dda06 to
121f1b2
Compare
Contributor
Author
|
Ci is green @nikophil I dunno why it seems to not fully work for psalm phpdoc but seems the issue is only for PeristentProxyObjectFactory (and proxy is deprecated) I think it's ok. |
Contributor
Author
|
Is it ok to be merged ? |
nikophil
approved these changes
Dec 9, 2025
Member
|
yes of course, sorry, I don't have much time to allocate to Foundry these days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nikophil