Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: skip legacy proxy tests using #[RequiresMethod]#1048

Merged
nikophil merged 1 commit into
zenstruck:2.xfrom
nikophil:chore/skip-legacy-proxy-tests-with-RequiresMethod-attribute
Dec 29, 2025
Merged

chore: skip legacy proxy tests using #[RequiresMethod]#1048
nikophil merged 1 commit into
zenstruck:2.xfrom
nikophil:chore/skip-legacy-proxy-tests-with-RequiresMethod-attribute

Conversation

@nikophil
Copy link
Copy Markdown
Member

@nikophil nikophil commented Dec 29, 2025

I just discovered #[RequiresMethod]. I think it is cleaner to use this attribute than the current solution used to skip those tests along with SF 8 (currently, we automatically add --exclude-group legacy-proxy when SF 8 is detected)

@nikophil nikophil marked this pull request as draft December 29, 2025 18:21
@nikophil nikophil force-pushed the chore/skip-legacy-proxy-tests-with-RequiresMethod-attribute branch from b901785 to 5a591b0 Compare December 29, 2025 18:27
@nikophil nikophil force-pushed the chore/skip-legacy-proxy-tests-with-RequiresMethod-attribute branch from 5a591b0 to aa06987 Compare December 29, 2025 18:32
@nikophil nikophil marked this pull request as ready for review December 29, 2025 18:37
@nikophil nikophil merged commit 368e686 into zenstruck:2.x Dec 29, 2025
67 checks passed
@nikophil nikophil deleted the chore/skip-legacy-proxy-tests-with-RequiresMethod-attribute branch December 29, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant