fix: proxying of classes that have tenative return types#962
Merged
nikophil merged 1 commit intoAug 6, 2025
Conversation
The symfony Proxy Helper will add a `ReturnTypeWillChange` attribute to methods with tenative return types. The regex wasn't able to handle attributes on methods so it wouldn't add the `_autoRefresh`. The 'best' example of this is jsonSerialize
Member
|
TIL the term of "tenative return types" 😅 thanks @BackEndTea |
Contributor
Author
|
Thanks for the quick merge @nikophil ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symfony Proxy Helper will add a
ReturnTypeWillChangeattribute to methods with tenative return types.The regex wasn't able to handle attributes on methods so it wouldn't add the
_autoRefresh.The 'best' example of this is jsonSerialize