fix(autorefresh): return fresh data from RepositoryDecorator methods#983
Merged
Merged
Conversation
nikophil
commented
Sep 21, 2025
| * @var \WeakMap<object, bool> | ||
| */ | ||
| private static $buffer = []; | ||
| private static \WeakMap $buffer; |
Member
Author
There was a problem hiding this comment.
finally I'm using a weak map 😄
this prevents to have duplicates in the buffer
9fafc98 to
b4301f4
Compare
b4301f4 to
0acd710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #975
The problem did exist before autorefresh with lazy objects, but we just never noticed it, and it was hidden by proxy mechanism 🤷
The root problem here is that
EntityRepository::findBy()(and all other related methods likefindAll(), etc..) do not actually return a fresh object if the object is already managed.What's surprising is that Doctrine actually performs the query to the db, but it just don't hydrate the object, unless a hint is passed. This optimization is just here to prevent hydration. The behavior is the same in ORM and in ODM
This is annoying, because hints can only be passed if a query builder is used. So we cannot use anymore
ObjectRepository::findBy()and other nice helper methods