DataWeave: Adding support for DataWeave language #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Nov 27, 2020
There was a problem hiding this comment.
Thank you for making this language definition @machaval!
There are a few things that have to be improved but overall solid work!
|
Thanks for all the feedback I will do the required changes ASAP |
|
All requested changes have been fixed now. Let me know if there is anything else you would like to be changed. Again thanks for all the comments you are the Regex master! |
RunDevelopment
requested changes
Nov 27, 2020
There was a problem hiding this comment.
Thank you for the quick response @machaval!
I left you a few comments again. A few regexes and rules can be simplified and I also have some questions.
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
approved these changes
Nov 27, 2020
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for dataweave language.
As seen in this snippet github already supports this language