Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Narrow return types for AbstractQuery::getSingleScalarResult()#10721

Merged
greg0ire merged 1 commit into
doctrine:2.16.xfrom
phansys:query_single_result
May 23, 2023
Merged

Narrow return types for AbstractQuery::getSingleScalarResult()#10721
greg0ire merged 1 commit into
doctrine:2.16.xfrom
phansys:query_single_result

Conversation

@phansys
Copy link
Copy Markdown
Contributor

@phansys phansys commented May 23, 2023 •
edited
Loading

Tests were also improved:

Closes #10695

@phansys phansys force-pushed the query_single_result branch 3 times, most recently from 9855225 to af3071a Compare May 23, 2023 00:59
@phansys phansys marked this pull request as ready for review May 23, 2023 01:07
@phansys phansys mentioned this pull request May 23, 2023
Closed
greg0ire
greg0ire reviewed May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be 2 commits if you are doing unrelated things. Also, mixed is technically correct, so the commit about changing the phpdoc should target 2.16.x (while the other commit should target 2.15.x to reduce differences, since it does not touch lib).
I've noticed that scalar is a type that exist for static analysis: https://psalm.dev/docs/annotating_code/type_syntax/scalar_types/#scalar

I'm undecided on whether we should use it or not, I would be OK with any solution.

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented May 23, 2023

There should be 2 commits if you are doing unrelated things.

TIL, I never created a PR with commits targeting different branches.

I've noticed that scalar is a type that exist for static analysis

I didn't used scalar in order to keep support for other tools that only recognize native types.

@phansys phansys force-pushed the query_single_result branch from af3071a to 6b70699 Compare May 23, 2023 08:44
@phansys phansys changed the base branch from 2.15.x to 2.16.x May 23, 2023 08:46
@phansys phansys force-pushed the query_single_result branch from 6b70699 to be297b9 Compare May 23, 2023 08:48
@phansys phansys requested a review from greg0ire May 23, 2023 08:48
@greg0ire greg0ire merged commit d951aa0 into doctrine:2.16.x May 23, 2023
@greg0ire greg0ire added this to the 2.16.0 milestone May 23, 2023
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented May 23, 2023

Thanks @phansys !

@phansys phansys deleted the query_single_result branch May 23, 2023 09:40
@github-actions github-actions Bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

No one assigned

Labels

Static Analysis

Projects

None yet

Milestone

2.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@phansys @greg0ire