Fix attach entity listener when reset class metadata factory#10786
Merged
greg0ire merged 2 commits intoJun 27, 2023
Conversation
greg0ire
previously approved these changes
Jun 22, 2023
Member
greg0ire
left a comment
There was a problem hiding this comment.
I found this suspicious at first, but this does not seem to break any tests so…
| } | ||
| } | ||
|
|
||
| unset($this->entityListeners[$metadata->name]); |
Member
There was a problem hiding this comment.
Looking at this listener, what it does is attach entity listeners as soon as class metadata is loaded. After that, it considers its job done forever, hence the unset (to save memory I guess).
SenseException
requested changes
Jun 25, 2023
This comment was marked as resolved.
This comment was marked as resolved.
greg0ire
approved these changes
Jun 27, 2023
SenseException
approved these changes
Jun 27, 2023
Member
|
Thanks @vuongxuongminh ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resetting entity manager via registry, if we use
Doctrine\ORM\Tools\AttachEntityListenersListenerto add entity event listeners, it can not be reattached because it delete listener after add on the first time then we will lose all entity listeners after reset entity manager.Symfony entity listener example:
and console command execution:
Expect
It work!should be printed twice but only once.