This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Disable gRPC ServiceConfig look up #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
============================================
+ Coverage 77.43% 77.44% +<.01%
Complexity 1081 1081
============================================
Files 196 196
Lines 4707 4708 +1
Branches 369 369
============================================
+ Hits 3645 3646 +1
Misses 895 895
Partials 167 167
Continue to review full report at Codecov.
|
7 tasks
andreamlin
approved these changes
Jun 5, 2019
This was referenced Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable resolution of the gRPC ServiceConfig from the DNS TXT records to prevent sudden duplication of retry logic should a service owner publish a RetryPolicy. More context in googleapis/gapic-generator#2778.