fix: new java format dependencies and linter fix #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Warning: This pull request is touching the following templated files:
|
1 task
Neenu1995
previously approved these changes
Nov 8, 2021
.github/workflows/ci.yaml
Outdated
| strategy: | ||
| matrix: | ||
| java: [7, 8, 11] | ||
| java: [8, 11] |
There was a problem hiding this comment.
FYI. Java client libraries check java 8, 11 and 17.
|
Owlbot check is failing because owlbot image has changed to |
Neenu1995
approved these changes
Nov 9, 2021
chanseokoh
reviewed
Nov 11, 2021
| <dependency> | ||
| <groupId>com.google.auto.value</groupId> | ||
| <artifactId>${project.auto-value-annotations.version}</artifactId> | ||
| <version>1.8.2</version> |
There was a problem hiding this comment.
Shouldn't this be ${project.auto-service-annotations.version}?
There was a problem hiding this comment.
Actually, the whole thing seems wrong. I'm surprised this doesn't fail.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
The dependencies were added in #768. Obviously, `artifactId`s are wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three current build issues due to version updates: