fix: Remove bidi modacks on StreamingPull initial request (#738)

acocuzzo · web-flow · commit 1e7d46901c44 · 2022-07-15T14:09:12.000-04:00
diff --git a/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py b/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
@@ -927,20 +927,11 @@ def _get_initial_request(
             A request suitable for being the first request on the stream (and not
             suitable for any other purpose).
         """
-        # Any ack IDs that are under lease management need to have their
-        # deadline extended immediately.
-        if self._leaser is not None:
-            # Explicitly copy the list, as it could be modified by another
-            # thread.
-            lease_ids = list(self._leaser.ack_ids)
-        else:
-            lease_ids = []
-
         # Put the request together.
         request = gapic_types.StreamingPullRequest(
-            modify_deadline_ack_ids=list(lease_ids),
-            modify_deadline_seconds=[self.ack_deadline] * len(lease_ids),
             stream_ack_deadline_seconds=stream_ack_deadline_seconds,
+            modify_deadline_ack_ids=[],
+            modify_deadline_seconds=[],
             subscription=self._subscription,
             client_id=self._client_id,
             max_outstanding_messages=(
diff --git a/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py b/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py
@@ -1318,8 +1318,8 @@ def test__get_initial_request():
     assert isinstance(initial_request, gapic_types.StreamingPullRequest)
     assert initial_request.subscription == "subscription-name"
     assert initial_request.stream_ack_deadline_seconds == 123
-    assert initial_request.modify_deadline_ack_ids == ["1", "2"]
-    assert initial_request.modify_deadline_seconds == [10, 10]
+    assert initial_request.modify_deadline_ack_ids == []
+    assert initial_request.modify_deadline_seconds == []
 
 
 def test__get_initial_request_wo_leaser():
