Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New DataSource: aws_ecr_repositories#34446

Merged
ewbankkit merged 21 commits into
hashicorp:mainfrom
brittandeyoung:f-aws_ecr_repositories
Dec 5, 2023
Merged

New DataSource: aws_ecr_repositories#34446
ewbankkit merged 21 commits into
hashicorp:mainfrom
brittandeyoung:f-aws_ecr_repositories

Conversation

@brittandeyoung
Copy link
Copy Markdown
Collaborator

@brittandeyoung brittandeyoung commented Nov 16, 2023 •
edited
Loading

Description

This PR introduces the new datasource aws_ecr_repositories.

Relations

Closes #12039

References

Output from Acceptance Testing

 make testacc TESTARGS='-run=TestAccECRRepositoriesDataSource' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRRepositoriesDataSource -timeout 360m
=== RUN   TestAccECRRepositoriesDataSource_basic
=== PAUSE TestAccECRRepositoriesDataSource_basic
=== CONT  TestAccECRRepositoriesDataSource_basic
--- PASS: TestAccECRRepositoriesDataSource_basic (51.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        54.899s

...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 16, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Nov 16, 2023
@terraform-aws-provider terraform-aws-provider Bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Nov 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 16, 2023

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@brittandeyoung brittandeyoung changed the title [WIP] New DataSource: aws_ecr_repositories New DataSource: aws_ecr_repositories Nov 16, 2023
@brittandeyoung brittandeyoung marked this pull request as draft November 16, 2023 19:33
@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. labels Nov 16, 2023
@github-actions github-actions Bot added client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Nov 16, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 16, 2023
@brittandeyoung brittandeyoung marked this pull request as ready for review November 16, 2023 21:32
ewbankkit
ewbankkit approved these changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRRepositoriesDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRRepositoriesDataSource_ -timeout 360m
=== RUN   TestAccECRRepositoriesDataSource_basic
=== PAUSE TestAccECRRepositoriesDataSource_basic
=== CONT  TestAccECRRepositoriesDataSource_basic
--- PASS: TestAccECRRepositoriesDataSource_basic (19.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	24.782s

@ewbankkit
Copy link
Copy Markdown
Contributor

ewbankkit commented Dec 5, 2023

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 54f9d4d into hashicorp:main Dec 5, 2023
@github-actions github-actions Bot added this to the v5.30.0 milestone Dec 5, 2023
@ewbankkit ewbankkit mentioned this pull request Dec 5, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

No one assigned

Labels

client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-data-source Introduces a new data source. service/ecr Issues and PRs that pertain to the ecr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v5.30.0

Development

Successfully merging this pull request may close these issues.

terraform data source filter wildcard for aws_ecr_repository

3 participants

@brittandeyoung @ewbankkit @justinretzolk