Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[New Data Source]: aws_emr_supported_instance_types#34481

Merged
jar-b merged 3 commits into
mainfrom
f-emr_supported_instance_types
Nov 21, 2023
Merged

[New Data Source]: aws_emr_supported_instance_types#34481
jar-b merged 3 commits into
mainfrom
f-emr_supported_instance_types

Conversation

@jar-b
Copy link
Copy Markdown
Member

@jar-b jar-b commented Nov 20, 2023

Description

Returns a list of supported instance types for the provided release label (ie. emr-6.15.0).

Also adds a V2 EMR service client and flex flatteners to support float32 builtin type conversions to framework Float64 types.

Relations

Closes #34438
Relates #33998

References

Output from Acceptance Testing

% make testacc PKG=emr TESTS=TestAccEMRSupportedInstanceTypesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRSupportedInstanceTypesDataSource_'  -timeout 360m
=== RUN   TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT  TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (31.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        35.082s

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 20, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Nov 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 20, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider Bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 20, 2023
@jar-b jar-b force-pushed the f-emr_supported_instance_types branch from ca2a223 to 25d6709 Compare November 20, 2023 19:07
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Nov 21, 2023
@ewbankkit
Copy link
Copy Markdown
Contributor

ewbankkit commented Nov 21, 2023

Needs a CHANGELOG entry.

ewbankkit
ewbankkit approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRSupportedInstanceTypesDataSource_' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRSupportedInstanceTypesDataSource_ -timeout 360m
=== RUN   TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT  TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (24.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	30.780s

@jar-b jar-b force-pushed the f-emr_supported_instance_types branch from 25d6709 to ec8c6be Compare November 21, 2023 14:54
@jar-b
Copy link
Copy Markdown
Member Author

jar-b commented Nov 21, 2023

After rebasing with recent dependency upgrades:

% make testacc PKG=emr TESTS=TestAccEMRSupportedInstanceTypesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRSupportedInstanceTypesDataSource_'  -timeout 360m
=== RUN   TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT  TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (31.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        35.404s

@jar-b jar-b merged commit cfec785 into main Nov 21, 2023
@jar-b jar-b deleted the f-emr_supported_instance_types branch November 21, 2023 15:24
@github-actions github-actions Bot added this to the v5.27.0 milestone Nov 21, 2023
github-actions Bot pushed a commit that referenced this pull request Nov 21, 2023
Update CHANGELOG.md for #34481
ae17eb7
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2023

This functionality has been released in v5.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 28, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

No one assigned

Labels

client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v5.27.0

Development

Successfully merging this pull request may close these issues.

New data source: aws_emr_supported_instance_types

2 participants

@jar-b @ewbankkit