Thanks to visit codestin.com
Credit goes to github.com

Skip to content

F securitylake data lake#34521

Merged
ewbankkit merged 50 commits into
hashicorp:mainfrom
markoskandylis:f-securitylake-data-lake
Dec 7, 2023
Merged

F securitylake data lake#34521
ewbankkit merged 50 commits into
hashicorp:mainfrom
markoskandylis:f-securitylake-data-lake

Conversation

@markoskandylis
Copy link
Copy Markdown
Contributor

@markoskandylis markoskandylis commented Nov 22, 2023 •
edited
Loading

Description

Adds support for Security Lake Data Lake

Relations

Relates #29376

References

https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateDataLake.html

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccSecurityLakeDataLake_' PKG=securitylake  ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securitylake/... -v -count 1 -parallel 1  -run=TestAccSecurityLakeDataLake_ -timeout 360m
=== RUN   TestAccSecurityLakeDataLake_basic
=== PAUSE TestAccSecurityLakeDataLake_basic
=== RUN   TestAccSecurityLakeDataLake_lifeCycle
=== PAUSE TestAccSecurityLakeDataLake_lifeCycle
=== RUN   TestAccSecurityLakeDataLake_lifeCycleUpdate
=== PAUSE TestAccSecurityLakeDataLake_lifeCycleUpdate
=== RUN   TestAccSecurityLakeDataLake_replication
=== PAUSE TestAccSecurityLakeDataLake_replication
=== RUN   TestAccSecurityLakeDataLake_disappears
=== PAUSE TestAccSecurityLakeDataLake_disappears
=== CONT  TestAccSecurityLakeDataLake_basic
--- PASS: TestAccSecurityLakeDataLake_basic (67.70s)
=== CONT  TestAccSecurityLakeDataLake_replication
--- PASS: TestAccSecurityLakeDataLake_replication (123.44s)
=== CONT  TestAccSecurityLakeDataLake_disappears
--- PASS: TestAccSecurityLakeDataLake_disappears (64.08s)
=== CONT  TestAccSecurityLakeDataLake_lifeCycleUpdate
--- PASS: TestAccSecurityLakeDataLake_lifeCycleUpdate (109.89s)
=== CONT  TestAccSecurityLakeDataLake_lifeCycle
--- PASS: TestAccSecurityLakeDataLake_lifeCycle (77.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securitylake	446.043s
...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 22, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/securitylake Issues and PRs that pertain to the securitylake service. size/XL Managed by automation to categorize the size of a PR. labels Nov 22, 2023
@terraform-aws-provider terraform-aws-provider Bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 22, 2023
@github-actions github-actions Bot added the tags Pertains to resource tagging. label Nov 30, 2023
@markoskandylis markoskandylis marked this pull request as ready for review November 30, 2023 16:17
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 1, 2023
@ewbankkit ewbankkit self-assigned this Dec 6, 2023
@ewbankkit
r/aws_securitylake_data_lake: Fix Read.
881a173
@ewbankkit
r/aws_securitylake_data_lake: Ensure standalone (non-Org) account for…
7f0fed3 
… acceptance testing.
@ewbankkit
Add 'names.SecurityLakeEndpointID'.
3d01573
@ewbankkit
r/aws_securitylake_data_lake: Add 's3_bucket_arn' attribute.
14c7954
@ewbankkit
Fix 'testAccDataLake_replication'.
dd040ce
@ewbankkit
r/aws_securitylake_data_lake: Handle tag retrieval for resource's 're…
a21ecaf 
…gion' != configured AWS Region.
@ewbankkit
Merge branch 'main' into HEAD
8136b7c
@ewbankkit
Merge commit 'a21ecaf37d3785f837e261b2e7dc53396568c9d6' into HEAD
5db9232 
# Conflicts:
#	internal/service/securitylake/data_lake.go
#	internal/service/securitylake/data_lake_test.go
@ewbankkit
Merge 276b23f, 9984e3d and 9560d75.
14c5da5
@ewbankkit
Run 'go generate ./internal/service/securitylake'.
b177df3
@ewbankkit
r/aws_securitylake_data_lake: Pass Region to 'listTags'.
93f7700
@ewbankkit
Fix 'testAccDataLake_basic'.
854a5e0
@ewbankkit
r/aws_securitylake_data_lake: encryption_configuration is a nested at…
7b24991 
…tribute.
@ewbankkit
Fix 'testAccDataLake_replication'.
dc7a242
@ewbankkit
Fix typo in acceptance test checks.
d362d4b
ewbankkit
ewbankkit approved these changes Dec 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSecurityLake_serial/DataLake' PKG=securitylake
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securitylake/... -v -count 1 -parallel 20  -run=TestAccSecurityLake_serial/DataLake -timeout 360m
=== RUN   TestAccSecurityLake_serial
=== PAUSE TestAccSecurityLake_serial
=== CONT  TestAccSecurityLake_serial
=== RUN   TestAccSecurityLake_serial/DataLake
=== RUN   TestAccSecurityLake_serial/DataLake/tags
=== RUN   TestAccSecurityLake_serial/DataLake/lifecycle
=== RUN   TestAccSecurityLake_serial/DataLake/lifecycleUpdate
=== RUN   TestAccSecurityLake_serial/DataLake/replication
=== RUN   TestAccSecurityLake_serial/DataLake/basic
=== RUN   TestAccSecurityLake_serial/DataLake/disappears
--- PASS: TestAccSecurityLake_serial (353.74s)
    --- PASS: TestAccSecurityLake_serial/DataLake (353.74s)
        --- PASS: TestAccSecurityLake_serial/DataLake/tags (66.51s)
        --- PASS: TestAccSecurityLake_serial/DataLake/lifecycle (60.69s)
        --- PASS: TestAccSecurityLake_serial/DataLake/lifecycleUpdate (69.03s)
        --- PASS: TestAccSecurityLake_serial/DataLake/replication (73.25s)
        --- PASS: TestAccSecurityLake_serial/DataLake/basic (45.68s)
        --- PASS: TestAccSecurityLake_serial/DataLake/disappears (38.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securitylake	359.223s

@ewbankkit
Copy link
Copy Markdown
Contributor

ewbankkit commented Dec 7, 2023

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7e706c1 into hashicorp:main Dec 7, 2023
@github-actions github-actions Bot added this to the v5.30.0 milestone Dec 7, 2023
This was referenced Dec 7, 2023
Closed
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Dec 8, 2023
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/securitylake Issues and PRs that pertain to the securitylake service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v5.30.0

Development

Successfully merging this pull request may close these issues.

2 participants

@markoskandylis @ewbankkit