Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix initial Wall Connector values in Tessie#121353

Merged
frenck merged 1 commit into
home-assistant:devfrom
Bre77:tessie-energy-valuefix
Jul 6, 2024
Merged

Fix initial Wall Connector values in Tessie#121353
frenck merged 1 commit into
home-assistant:devfrom
Bre77:tessie-energy-valuefix

Conversation

@Bre77
Copy link
Copy Markdown
Contributor

@Bre77 Bre77 commented Jul 6, 2024

Proposed change

_async_update_attrs isnt being run at start up for Wall Connectors, which is causing entities to have an initial unknown value. This gets fixed after the first refresh, but this PR makes it correct from the start (including the snapshot)

Suitable for a point release, but not urgent since its fixes itself after first refresh.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Bre77 Bre77 changed the title Fix _async_update_attrs in Tessie Fix inital Wall Connector values in Tessie Jul 6, 2024
@Bre77 Bre77 changed the title Fix inital Wall Connector values in Tessie Fix initial Wall Connector values in Tessie Jul 6, 2024
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Bre77 👍

../Frenck

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 6, 2024

Should we drop this in a patch release? Let's me know 👍

../Frenck

@frenck frenck merged commit 294c31f into home-assistant:dev Jul 6, 2024
@Bre77
Copy link
Copy Markdown
Contributor Author

Bre77 commented Jul 6, 2024

Should we drop this in a patch release? Let's me know 👍

../Frenck

@frenck I think so.

@frenck frenck added this to the 2024.7.2 milestone Jul 6, 2024
@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 6, 2024

Ok, marked for 2024.7.2

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants