Add naming requirement for outlet controller identifiers to docs#679
Merged
Conversation
AndersGM
pushed a commit
to AndersGM/stimulus
that referenced
this pull request
Jun 16, 2023
…wired#679) * Add naming requirement for outlet controller identifiers to docs * Update outlets.md --------- Co-authored-by: David Heinemeier Hansson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋
Something we ran into when trying to use outlets was not noticing that the identifier used for the outlet must match the registered controller name exactly. This was also brought up in this issue. The fact that the naming convention for outlets is different to targets is another matter, and one which is being discussed (would be a great improvement).
I realise this seems to be one of many PRs related to improving the outlets documentation, so if it's one too many then feel free to close it, but this one sentence probably would have saved us some time (assuming we read it of course!).