fix(bootstrap): Run lifecycle scripts in topological queue instead of batches (#2224)

nicolo-ribaudo · evocateur · commit d8d33f7bdc7e · 2019-10-07T11:02:39.000-07:00
diff --git a/commands/bootstrap/index.js b/commands/bootstrap/index.js
@@ -14,8 +14,7 @@ const rimrafDir = require("@lerna/rimraf-dir");
 const hasNpmVersion = require("@lerna/has-npm-version");
 const npmInstall = require("@lerna/npm-install");
 const { createRunner } = require("@lerna/run-lifecycle");
-const batchPackages = require("@lerna/batch-packages");
-const runParallelBatches = require("@lerna/run-parallel-batches");
+const runTopologically = require("@lerna/run-topologically");
 const symlinkBinary = require("@lerna/symlink-binary");
 const symlinkDependencies = require("@lerna/symlink-dependencies");
 const ValidationError = require("@lerna/validation-error");
@@ -178,10 +177,6 @@ class BootstrapCommand extends Command {
     });
 
     chain = chain.then(() => {
-      this.batchedPackages = this.toposort
-        ? batchPackages(this.filteredPackages, this.options.rejectCycles)
-        : [this.filteredPackages];
-
       if (npmClient === "yarn" && !mutex) {
         return getPort({ port: 42424, host: "0.0.0.0" }).then(port => {
           this.npmConfig.mutex = `network:${port}`;
@@ -281,9 +276,14 @@ class BootstrapCommand extends Command {
 
     tracker.addWork(this.filteredPackages.length);
 
-    return pFinally(runParallelBatches(this.batchedPackages, this.concurrency, mapPackageWithScript), () =>
-      tracker.finish()
-    );
+    const runner = this.toposort
+      ? runTopologically(this.filteredPackages, mapPackageWithScript, {
+          concurrency: this.concurrency,
+          rejectCycles: this.options.rejectCycles,
+        })
+      : pMap(this.filteredPackages, mapPackageWithScript, { concurrency: this.concurrency });
+
+    return pFinally(runner, () => tracker.finish());
   }
 
   hoistedDirectory(dependency) {
diff --git a/commands/bootstrap/package.json b/commands/bootstrap/package.json
@@ -36,7 +36,6 @@
     "populate--": true
   },
   "dependencies": {
-    "@lerna/batch-packages": "file:../../utils/batch-packages",
     "@lerna/command": "file:../../core/command",
     "@lerna/filter-options": "file:../../core/filter-options",
     "@lerna/has-npm-version": "file:../../utils/has-npm-version",
@@ -45,7 +44,7 @@
     "@lerna/pulse-till-done": "file:../../utils/pulse-till-done",
     "@lerna/rimraf-dir": "file:../../utils/rimraf-dir",
     "@lerna/run-lifecycle": "file:../../utils/run-lifecycle",
-    "@lerna/run-parallel-batches": "file:../../utils/run-parallel-batches",
+    "@lerna/run-topologically": "file:../../utils/run-topologically",
     "@lerna/symlink-binary": "file:../../utils/symlink-binary",
     "@lerna/symlink-dependencies": "file:../../utils/symlink-dependencies",
     "@lerna/validation-error": "file:../../core/validation-error",
diff --git a/package-lock.json b/package-lock.json
