Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/playwright
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.41.1
Choose a base ref
...
head repository: microsoft/playwright
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.41.2
Choose a head ref
  • 3 commits
  • 21 files changed
  • 4 contributors

Commits on Jan 29, 2024

  1. cherry-pick(#29180): fix: interception id not found error in route.co… (

    #29222)
    
    …ntinue
    
    We stopped catching all exceptions in
    #28539 in hope that we'll
    get loadingFailed even before Fetch.continue/fulfill command's error.
    Turns out this is racy and may fail if the test cancels the request
    while we are continuing it. The following test could in theory reproduce
    it if stars align and the timing is good:
    
    ```js
    it('page.continue on canceled request', async ({ page }) => {
      let resolveRoute;
      const routePromise = new Promise<Route>(f => resolveRoute = f);
      await page.route('http://test.com/x', resolveRoute);
    
      const evalPromise = page.evaluate(async () => {
        const abortController = new AbortController();
        (window as any).abortController = abortController;
        return fetch('http://test.com/x', { signal: abortController.signal }).catch(e => 'cancelled');
      });
      const route = await routePromise;
      void page.evaluate(() => (window as any).abortController.abort());
      await new Promise(f => setTimeout(f, 10));
      await route.continue();
      const req = await evalPromise;
      expect(req).toBe('cancelled');
    });
    ```
    
    Fixes #29123
    yury-s authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7a72adc View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. cherry-pick(#29271): Revert "chore: remove fake error from expect c…

    …alls (#28112)" (#29296)
    
    This PR cherry-picks the following commits:
    
    - 622153d
    
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    playwrightmachine and github-actions[bot] authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    414affa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a409667 View commit details
    Browse the repository at this point in the history
Loading