[DataGrid] Fix column separators#12808
Merged
Merged
Conversation
|
Deploy preview: https://deploy-preview-12808--material-ui-x.netlify.app/ |
MBilalShafi
reviewed
Apr 17, 2024
Member
There was a problem hiding this comment.
It might not be related to this PR, but I observed that that width of last column separator is always less than the rest. Is it known/intentional? Possibly due to overflow: hidden?
lastColumn.mp4
Contributor
Author
There was a problem hiding this comment.
Intentional, for the reasons listed above.
|
I noticed that when I needed to set |
Contributor
Author
|
I'd rather not add code if there's already a way to do it. |
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Andrew Cherniavskyi <[email protected]>
1 task
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Andrew Cherniavskyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12788
Closes #12783
Fix column separators, make the separators from their full width. The last column is
overflow: hiddenbecause otherwise the flex layout is messed up due to the separator sticking out of the row width.Preview: https://deploy-preview-12808--material-ui-x.netlify.app/x/react-data-grid/column-dimensions/