Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TreeView] Support defaultMuiPrevented on the onFocus prop of the root slot#12813

Merged
flaviendelangle merged 2 commits into
mui:masterfrom
flaviendelangle:misc-tree-view
Apr 18, 2024
Merged

[TreeView] Support defaultMuiPrevented on the onFocus prop of the root slot#12813
flaviendelangle merged 2 commits into
mui:masterfrom
flaviendelangle:misc-tree-view

Conversation

@flaviendelangle
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle commented Apr 17, 2024

This is clearly a nitpick but let's be consistent 👌
Unless I'm missing some prop, we now support defaultMuiPrevented on all the props of the Tree View components and TreeItem2 (not the legacy TreeItem).

@flaviendelangle flaviendelangle added the scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. label Apr 17, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 17, 2024
};
};

const isItemExpandable = (reactChildren: React.ReactNode) => {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, this function was not using its scope

@mui-bot
Copy link
Copy Markdown

mui-bot commented Apr 17, 2024

Deploy preview: https://deploy-preview-12813--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d557ffa

@flaviendelangle flaviendelangle requested a review from LukasTy April 17, 2024 15:58
@flaviendelangle flaviendelangle marked this pull request as ready for review April 17, 2024 15:58
Copy link
Copy Markdown
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@flaviendelangle flaviendelangle merged commit de60920 into mui:master Apr 18, 2024
@flaviendelangle flaviendelangle deleted the misc-tree-view branch April 18, 2024 11:41
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: tree view Changes related to the tree view. This includes TreeView, TreeItem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants