Conversation
Contributor
susnux
commented
Dec 6, 2022
- Updated rollup to new major version 3.x (3.6.0) and also updated corresponding dependencies
- Adjusted tsconfig to run cypress using ES modules (ES2015 is the latest supported version by cypress 11)
- Fixes / Supersedes Bump rollup from 2.79.1 to 3.2.5 #94
2c8d932 to
5b79fae
Compare
skjnldsv
reviewed
Dec 6, 2022
37b0071 to
2147862
Compare
Contributor
|
Please do not upgrade cypress, this is broken |
skjnldsv
reviewed
Dec 6, 2022
Contributor
Author
Had some hopes as at least 1 of 2 workflows succeeded |
Contributor
Me too. But this is also not related to this PR. Patchwork PRs should be avoided :) |
2147862 to
f445b23
Compare
Contributor
Author
|
The cypress tests now succeed, the issue was related to module handling which changed in rollup I guess the Node errors are unrelated? |
50bf930 to
8eea686
Compare
8eea686 to
189cead
Compare
Contributor
Author
|
I had to remove the node 14 test as node 14 fails with |
skjnldsv
requested changes
Dec 8, 2022
* Updated rollup to new major version 3.x (3.6.0) and also updated corresponding dependencies * Adjusted tsconfig to run cypress using ES modules (ES2015 is the latest supported version by cypress 11) Signed-off-by: Ferdinand Thiessen <[email protected]>
189cead to
95c7459
Compare
skjnldsv
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.