fix(core): use Date.now() everywhere for tasks start and end times to avoid negative durations #18595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid negative durations Closes nrwl#18388
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
approved these changes
Aug 11, 2023
FrozenPandaz
approved these changes
Aug 15, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We use
performance.nowfor start time and end time of tasks in the perf lifecycle hook, unless the tasks specify it (which is important for batch mode, when multiple tasks are reported at the same time but with different start and end times). Batch mode tasks report viaDate.nowinstead, which can cause negative durationsExpected Behavior
No negative durations
Additional info
We decided to move away from
performance.nowhere, partially because jest reports start and end time relative to UTC and it would be harder to compute.Related Issue(s)
Closes #18388