Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(nx-dev): move openai call to edge function #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

feat(nx-dev): move openai call to edge function #18747

merged 1 commit into from
Aug 24, 2023

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Aug 21, 2023 •
edited
Loading

Moved the OpenAI API calls into a Next.js Edge function, so that the API key is not revealed to the client!

test it here: https://nx-dev-git-fork-mandarini-feat-move-openai-call-to-edge-nrwl.vercel.app/ai

@vercel
Copy link

vercel bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 11:20am

@mandarini mandarini self-assigned this Aug 21, 2023
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Aug 21, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c36c59c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch from 1c51c3f to dfcb380 Compare August 23, 2023 12:42
@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch 3 times, most recently from 5146fca to aaa073b Compare August 23, 2023 12:58
@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch from 6ca2a3b to fd57c75 Compare August 23, 2023 13:31
@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch from fd57c75 to 1e04ff3 Compare August 23, 2023 13:49
@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch 3 times, most recently from a2cc439 to de57d37 Compare August 23, 2023 14:12
@mandarini mandarini marked this pull request as ready for review August 23, 2023 14:12
@mandarini mandarini requested a review from a team as a code owner August 23, 2023 14:12
ndcunningham
ndcunningham previously approved these changes Aug 23, 2023
View reviewed changes
ndcunningham
ndcunningham reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{
    "code": "42501",
    "details": null,
    "hint": null,
    "message": "new row violates row-level security policy for table \"user_queries\""
}

I got this error when running the preview.
Is this something we should handle?

@ndcunningham ndcunningham self-requested a review August 23, 2023 15:26
@ndcunningham ndcunningham dismissed their stale review August 23, 2023 15:27

Found an error

ndcunningham
ndcunningham reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ndcunningham ndcunningham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle supabase calls as well?
Screenshot 2023-08-23 at 9 32 09 AM

@mandarini
Copy link
Contributor Author

@ndcunningham RE: supabase: I don't think we need to handle the Supabase stuff, because @FrozenPandaz added the anon key there, which is ok to be revealed?

@mandarini mandarini force-pushed the feat/move-openai-call-to-edge branch from de57d37 to c36c59c Compare August 24, 2023 11:13
@mandarini
Copy link
Contributor Author

@ndcunningham the feedback error is expected, because we changed some things with permissions. Next week I'll work on the new feedback functions, and it will be fixed!

@mandarini mandarini requested a review from ndcunningham August 24, 2023 11:38
@ndcunningham ndcunningham enabled auto-merge (squash) August 24, 2023 15:20
@ndcunningham ndcunningham disabled auto-merge August 24, 2023 15:20
FrozenPandaz
FrozenPandaz approved these changes Aug 24, 2023
View reviewed changes
@mandarini mandarini enabled auto-merge (squash) August 24, 2023 15:50
@mandarini mandarini merged commit bd76b62 into nrwl:master Aug 24, 2023
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@bcabanes bcabanes Awaiting requested review from bcabanes

+2 more reviewers

@ndcunningham ndcunningham ndcunningham approved these changes

@isaacplmann isaacplmann isaacplmann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandarini mandarini

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandarini @ndcunningham @isaacplmann @FrozenPandaz