chore(badge): added screenreader to unread badges#5708
Merged
mcoker merged 1 commit intopatternfly:mainfrom Aug 1, 2023
Merged
chore(badge): added screenreader to unread badges#5708mcoker merged 1 commit intopatternfly:mainfrom
mcoker merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-pr-5708.surge.sh A11y report: https://patternfly-pr-5708-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
There was a problem hiding this comment.
This looks good! Only couple things are:
- There are a couple of unrelated commits as part of the PR
- I'd defer to @mcoker regarding the formatting of the handlebars. Other instances of the screen-reader handlebars as it on a separate line from other content, but it might make more sense in those contexts
ea4cc84 to
81e2c04
Compare
thatblindgeye
approved these changes
Jul 10, 2023
Contributor
thatblindgeye
left a comment
There was a problem hiding this comment.
🎉 Thanks for making the update!
Collaborator
|
🎉 This PR is included in version 5.1.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #5230